[Bug 151] Review Request: systemc - Design and verification language for Hardware

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=151





--- Comment #16 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-12-15 01:48:50 ---
* Patch 0 and Patch1 contain unnecessary bits. Please clean them up and make
the patches as plain as possible.

* Patch 3 is an empty patch file and it is applied twice. Did you forget
something?

* affected=`find src/ -type f -name "Makefile*" -exec ls {} ';'`
can be just
  affected=`find src/ -type f -name "Makefile*"`
As I noted before "ls" is not intended to be used in shell scripts.

* Please remove the comments such as
   #%{__sed} -i -e 's|prefix = @prefix@|prefix = %{SYSTEMC_HOME}|g' \
   #  examples/*/Makefile* \ 
   #  examples/*/*/Makefile* \
   #  examples/*/*/*/Makefile*
from the final version of the SPEC file. I'd also like to remind you that
whenever you want to use macros inside comments, you need to use %% instead of
single %.

* Don't use the %{version} macro for patch names. If you do, you will need to
re-upload them at each version. Either put explicit version number or no
version number at all.

* More important than anything else: This SRPM does not build!


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.