[Bug 67] Review Request: open-vm-tools - VMware Guest OS Tools

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=67


Thorsten Leemhuis <fedora at leemhuis.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rpmfusion-package-
                   |                            |review at rpmfusion.org
             Blocks|                            |3
         AssignedTo|rpmfusion-package-          |fedora at leemhuis.info
                   |review at rpmfusion.org        |




--- Comment #21 from Thorsten Leemhuis <fedora at leemhuis.info>  2008-11-02 12:19:06 ---
Okay, so a lot of people looked into this and the package got improved a lot.
It might not be perfect, but I think it's close to "good enough". To those that
looked closer at the packages: If you disagree please speak up now ;-)

It's just "close to good enough" because I found a few remaining issues; once
those are fixed I'll approve the package if no one raises other issues in
between

- Installing and immediately uninstalling the package afterwards results in a
few odd messages that get printed to the console:

$ LC_ALL=C sudo rpm -e kmod-open-vm-tools-2.6.27.4-19.fc9.x86_64.x86_64
open-vm-tools
vmware-guestd beenden: vmware-user: Kein Prozess abgebrochen
umount: /proc/fs/vmblock/mountPoint: Nicht gefunden
ERROR: Module vmblock does not exist in /proc/modules
[FEHLGESCHLAGEN]
$

That should get fixed

- This
ExclusiveArch: i386 i586 i686 x86_64
is normally correct, but plague will build the package for i586 and i686 if it
find such a ExcludeiveArch; to avoid that please change to 
ExclusiveArch: i386 x86_64
(feel free to add a explaining comment if you like)

- rpmlint finds a few things; I'd say those can get ignored; but would be nice
to get this fixed, as it might confuse users:
open-vm-tools.x86_64: W: no-reload-entry /etc/init.d/vmware-guestd

- one thing where I'm a bit unsure: The desktop file is in
%{_datadir}/gnome/autostart/; isn't /etc/xdg/autostart/ the better place for
this these days?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.