[Bug 96] Review request: broadcom wireless kmod (wl-kmod)

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=96





--- Comment #18 from Thorsten Leemhuis <fedora at leemhuis.info>  2008-11-04 11:01:47 ---
(In reply to comment #15)
> One thing:
> 
> For the broadcom-wl package I couldn't decide whether it was better to chmod
> the files in the %prep section and use -m0644 in %install or whether just to
> use
> 
> %defattr(644,root,root,755)
> 
> in the %files section? Both seem to achieve the same thing, but is one way
> better than the other?

I'd say using install with -m0644 is the best; one less line in the spec than a
explicit chmod during %prep; and a defattr might backfire sooner or later


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.