[Bug 124] Review request: pgplot - Graphic library for making simple scientific graphs

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=124


Orcan Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |3
              Alias|                            |pgplot
         AssignedTo|rpmfusion-package-          |orcanbahri at yahoo.com
                   |review at rpmfusion.org        |




--- Comment #4 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-11-11 08:24:31 ---
I saw the copyright.notice file in the original tarball. Please ignore the
previous message. The package is in good shape. Let us go through a few minor
things:

* rpmlint says:
   pgplot.x86_64: E: non-standard-executable-perm
/usr/lib64/libcpgplot.so.5.2.2 0775
   pgplot.x86_64: E: non-standard-executable-perm /usr/lib64/libpgplot.so.5.2.2
0775
   pgplot-tk.x86_64: E: non-standard-executable-perm
/usr/lib64/libtkpgplot.so.5.2.2 0775
These need fixed (to 755)

* Please package the Changelog files. If you want, you can concatenate them
with something like
   (for i in $(find . -name "ver*.txt" |sort -r); do cat $i; done) > ChangeLog

* We prefer defattr(-,root,root,-)

* Please make use of macros extensively and consistenly, especially the %{name}
macro, also e.g.
   %{__rm} -rf %{buildroot}
in one line and
   rm -fr %{buildroot}
on the other breaks consistency.

! Parallel make must be supported whenever possible. Write a comment on the
spec file if parallel make is not supported. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make

* Don't we need to put the copyright notice to all the subpackages, as is told
by the copyright notice itself?

* You are supplying external .pc files. I don't understand why you're editing
(sed'ding) them again. 

* Everything that is in the %build section until the "./makemake" line should
be moved into %prep .

* Definitions such as
   %define lvfull 5.2.2
   %define lvmajor 5
are usually put to the very beginning of the SPEC file. At least, somewhere
closer to the Version tag.
By the way, %{version} = %{lvfull} = 5.2.2 . Why are you defining the same
thing twice? I think you should do something like:
   %define lvmajor 5
   Name: pgplot
   Version: 5.2.2
   ...
and then use %{version} below instead of %{lvfull}.

* The tcl conventions have changed in Fedora 9. Please follow:
http://fedoraproject.org/wiki/Packaging/Tcl
see naming, installation locations etc.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.