[Bug 151] Review Request: systemc - Design and verification language for Hardware

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=151





--- Comment #4 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-11-28 17:01:02 ---
This package needs some work. rpmlint gives some ~300 warnings/errors. The main
reasons seems to be your unusual prefix for configure. 

-Why don't you use %{_usr} for prefix? Or just use %configure and it will take
care of it for you.
-I see you defining the $DESTDIR. But there is no reference to the $DESTDIR
anywhere in the Makefiles or the code.
-The contents of the include directory must go to a devel subpackage.
-The library is built static. Is there no way of making it dynamic?
-There are a lot of "wrong EOL encoding" warnings. You can use 
   sed 's/\r//' filename
to fix those. But make sure you preserve timestamps for the relevant files.
-There are bunch of binary files in the source tarball. For instance, the
.DS_Store files. You should remove all of them during %prep
-We don't mention the %buildroot during %prep. That comes in the %build and
%install sections.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.