[Bug 151] Review Request: systemc - Design and verification language for Hardware

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=151





--- Comment #7 from Chitlesh GOORAH <cgoorah at yahoo.com.au>  2008-11-30 15:49:51 ---
(In reply to comment #6)
> * Then I think we should follow the gcc scheme rather than creating a systemc
> directory directly inside /usr . gcc is installed in the path:
>    /usr/lib/gcc/x86_64-redhat-linux/4.3.2/

Now: /usr/lib/systemc/2.2.0/

> I don't like putting %{buildroot} into the prefix. You can use a
>    sed 's|\$(prefix)|\$(DESTDIR)/\$(prefix)|g'
> on the Makefile* and then use the DESTDIR trick you just removed. e.g.
>    %configure --prefix=%{_libdir}/%{name}/%{version}
> (or something similar) and then
>    %{__make} INSTALL="install -p" DESTDIR=%{buildroot} install

done

> * I also wonder why you don't use
>    gmake install

done

> * There are more precompiled binary files. e.g. .ncb files
> * Do we need to package the .vcproj files? They are for use of MS' visualC.

*.ncb and *.vcproj removed

> * The files README and doc/README are different. You are overwriting one the
> way you package the doc files. (Maybe you should use docs instead of docs/* in
> %doc or just rename one of these README files)

done

> * This one is for making the SPEC file plainer: Check 
>   rpm --eval %{optflags}
> to see what flags need to be there for compilation. You are removing some of
> these flags from the configure script. Removing them is unnecessary.

Because the build fails with the following :
cc1plus: error: unrecognized command line option "-fstack-protector"            
cc1plus: error: invalid parameter `ssp-buffer-size'
cc1plus: error: invalid parameter `ssp-buffer-size'
warning: #warning _FORTIFY_SOURCE supported only with GCC 4.1 and later  


> ? The debuginfo package is empty?

I have no clue how to fix this.

> * I am worried about the Requires. You are building this with g++34. Don't you
> think we need to require g++34 for this package? If someone writes a code with
> this library he needs to compile the code with g++34, right? And what about
> other (possible) dependencies?
> 

true, Requires:       compat-gcc-34-c++ was missing. But no other requires are
needed.

Updated

Spec URL: http://chitlesh.fedorapeople.org/systemC/systemc.spec
SRPM URL: http://chitlesh.fedorapeople.org/systemC/systemc-2.2.0-4.fc10.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.