[Bug 48] Review Request: freej - a vision mixer for video DJs on Linux

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=48





--- Comment #6 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-04-09 05:51:11 ---
This package definitely needs some work. Here are some blockers:

* Please remove the precompiled binary(ies) in %prep, e.g. 
    xcode/English.lproj/MainMenu.nib/designable.nib

* These files have "usr/lib/" and/or "usr/local/" hardcoded. Please fix these
via sed or patch:
    src/context.cpp
    src/plugger.cpp
    xcode/config.h

* Package does not build against gcc4.4:
   DEBUG:  g++ -DHAVE_CONFIG_H -I. -I.. -I.. -I../src/include -I../lib
-I../lib/ccvt -I../lib/shout -I../lib/lo -I../lib/sdl_image -I../lib/sdl_gfx
-I../lib/sdl_ttf -I../lib/flash -I../lib/goom -I../lib/cwiid
-I/usr/include/slang -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-I/usr/include/freetype2 -I/usr/include/unicap -I/usr/include/ffmpeg
-I/usr/include/ffmpeg/libavcodec -I/usr/include/ffmpeg/libavformat
-I/usr/include/ffmpeg/libswscale -I../lib/javascript -I../lib/javascript/obj
-freg-struct-return -DPREFIX=\"/usr\" -DDATADIR=\"/usr/share\" -pipe
-D_REENTRANT -freg-struct-return -fPIC -O2 -mfpmath=sse -mtune=nocona -O2 -MT
frei0r.lo -MD -MP -MF .deps/frei0r.Tpo -c frei0r.cpp  -fPIC -DPIC -o
.libs/frei0r.o                                                              
   DEBUG: frei0r.cpp: In member function 'int Freior::open(char*)':             
   DEBUG: frei0r.cpp:102: error: 'snprintf' was not declared in this scope      
   DEBUG: frei0r.cpp: In member function 'void Freior::print_info()':           
   DEBUG: frei0r.cpp:122: error: 'snprintf' was not declared in this scope

Please patch this up and try to build your packages in mock/rawhide beforehand
to see if they compile.

* rpmlint says:
   freej.src: W: mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 5)
which can be fixed easily

* You need to remove .la files from the final binary RPM.

* These need not be specified explicitly:
   Requires:       SDL SDL_ttf freetype slang
   Requires:       fftw jack-audio-connection-kit
   Requires:       unicap
these dependencies will be added automatically by rpmbuild.

* There are many libraries in the lib/ directory which are already present in
Fedora. You need to patch freej to use system libraries instead of those in the
lib/ directory. Even those that are not in Fedora should be packaged separately
and be submitted to Fedora.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.