[Bug 441] Review request: traverso - Multitrack Audio Recording and Editing Suite

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=441





--- Comment #13 from NicolasChauvet <kwizart at gmail.com>  2009-04-27 11:30:28 ---
* Please delete any internal dependency:
rm -rf src/3rdparty/slv2
(Rememeber that cmake list slv2 to be >=0.6.1 )

* Please append a versioned BuildRequirement when relevant.

* QT_PHONON_LIBRARY_RELEASE        QT_PHONON_LIBRARY_RELEASE-NOTFOUND
I'm not sure traverso will use photo, unless it needs qt 4.5.1.
same for
QT_QTMOTIF_LIBRARY_RELEASE       QT_QTMOTIF_LIBRARY_RELEASE-NOTFOUND
I don't know if it is relevant.


* Optims, I"ve successfully have built traverso using:
%{cmake}                                               \
         -DWANT_MP3_ENCODE=ON                          \
         -DUSE_SYSTEM_SLV2_LIBRARY=ON \
         .
And our CFLAGS were used. But it has also used some "not always available" asm
optim such as 3dnow. 
Vector optims seems MacOSX related (not linux on ppc), so the only important
feature is SSE on x86(_64) (possible with IA64 in theory?)

According to CMakeLists.txt , the DETECT_HOST_CPU_FEATURES rely on
/proc/cpuinfo and set various definition. It would be better to patch it to use
a cmake option, so sse can be enabled by a switch, and the various needed
options to be set.

According to the Fedora guideline, using SSE on x86 is illegal as not all CPU
have this feature on x86 (despite x86_64 at least have SSE2). If I let you
build a SSE enabled binary, at least I want a "cmake option" that will avoid
SSE without disabling x86 conditionalized code. Please forward this upstream if
necessary.

To sum-up:
buildtime autodetection should remains disabled. 
x86(_64) should be automatically detected according to the _target_cpu been
used.
SSE should be enabled by a cmake switch (default on x86_64)

* -DSTATIC_BUILD - This is used despite not been what we call a static library
built. This is weird since the code is conditionalized with STATIC_BUILD in two
places:
src/core/InputEngine.cpp
src/traverso/Main.cpp


* (In reply to comment #12)
...
> The CMakelist file foes not support it. @DOC_FILE@ is something that I have
> introduced by hand so that the program will guide Fedora users to the right
> documentation for setting up the /etc/security/limits.conf file. It's not a bad
> hack (check the patch traverso-warnings.patch).
Good god! that's an horrible hack!!!
Please avoid bundling pre-built pdf documentation , prefer to use the url
instead!!!

Furthermore i've tried to read the pdf (was fly reading actually) and found
rather hard to see if something needs to be tweaked in
/etc/security/limits.conf.
If something like this is needed, you might need to tweak it in %post from
traverso like jack-audio-connection-kit does.
It could be improved by only adding it on install, checks if the hack is
present already and remove the hack on uninstall.


* Fedora hacking. %{name}-defaults.patch
I don't understand why changing the number of period would solve things for
Fedora? Does it, really ? (of course, as i'm using PA, it doesn't solve
anything).


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.