[Bug 585] Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=585





--- Comment #18 from Thorsten Leemhuis <fedora at leemhuis.info>  2009-08-02 15:31:59 ---
Sorry, I wanted to review this weeks ago but was really busy with ohter issue;
I apologize for the long delay

General comment: the spec file is really scary; but well, I see no easy and
long-term-safe way how to clean that mess :-/

I noticed two things where I'm not really sure if they are right as they are:

- Will this part from the file section work if apache is not yet installed? 
%attr(-,apache,apache) %dir %{_localstatedir}/lib/zarafa/%{name}/state/
Afaics the user is created as a %pre script in apache, so I guess it won't
work. Maybe a "Requires(pre):" will do it (not sure, I never packaged or
reviewed PHP stuff up to now). Or am I missing something? And will that apache
perm really work if other webservers are used?

- Is "Requires: php >= 4" really the proper way for the dep here? Shouldn't
that be something like "php-api = %{php_apiver}" (at least on current Fedora?
might be different in EL land...)

Some other comments, just for completeness:

- Hmm, the license field is quite long an kind of breaks the output of "rpm
-qip z-push-1.2.2-1.src.rpm" -- but I see no easy way around that :-/

- is there any chance to get those patches and config files (or a different
solution to solve the problem at hand) upstream?

- this install document afaics might be helpful even for users of this rpm, so
you might want to consider shipping it (maybe in a adjusted way?) 

- did not try if this package actually works; trusting the packager in this
regard

- rpmlint:

arafa-z-push.noarch: W: invalid-license GPLv2 with clause 8 invoked
zarafa-z-push.noarch: W: invalid-license distribution in the US is forbidden
z-push.noarch: W: invalid-license GPLv2 with clause 8 invoked
z-push.noarch: W: invalid-license distribution in the US is forbidden
z-push.src: W: invalid-license GPLv2 with clause 8 invoked
z-push.src: W: invalid-license distribution in the US is forbidden
3 packages and 0 specfiles checked; 0 errors, 6 warnings.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.