[Bug 1015] Review request: gstreamer-plugins-bad-nonfree - Non Free GStreamer streaming media framework "bad" plug-ins

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1015


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4




--- Comment #5 from Lubomir Rintel <lkundrak at v3.sk>  2009-12-23 19:04:01 ---
* Named and versioned correctly
* Spec file clean and legible
* Uses correct compiler flags
* Filelist sane
* Requires/provides sane
* License tag ok

Needs work:

1.) Please add dependency on liboil-devel
configure demands it (though the resulting libraries don't seem to link against
it; maybe the liboil dependency can be patched away?). Please note that I was
too lazy to do a mockbuild, so you may encounter other missing dependencies
upon initial build. I hope that's not a problem.

2.) Please add V=2 parameter to make, so that actual commands are printed (and
thus checked for correctness)

3.) RPMlint:
gstreamer-plugins-bad-nonfree-debuginfo.i686: E: description-line-too-long This
package provides debug information for package gstreamer-plugins-bad-nonfree.
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

APPROVED

None of these really block the review, they can be addressed upon commit, along
with Kevin's suggestion (which I probably would not notice myself).


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.