[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030


rc040203 at freenet.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #1 from rc040203 at freenet.de  2009-12-31 11:35:53 ---
(In reply to comment #0)

[FWIW: I have a spec for xbmc of my own, but do not indent to publish it for
several, different reasons. The comments below are based on what I am observing
without having looked into your package.]

> Note that XBMC is a big package, the SRPM is 135 MB (although the binary is
> only 32 MB).
Much of the size stems from upstream including windows and osx binaries.
I'd recommend to prune them from their tarball.

> 1. The first issue (as revealed in the rpmlint log, below) is that xbmc
> installs no-arch independent code in /usr/share/xbmc/.  We probably need

s/need/MUST/
No go without having this fixed.

> to
> work with upstream to see how best to relocate these binaries to /usr/lib{64}/.
I have a patch addressing this issue. But am not yet sure my patch is complete,
because there are several places in xbmc which have /usr/share hard-wired.

>  The non-executable script messages result from plugins .py files that are run
> from within xbmc, but not by users, I believe.
>
> # rpmlint xbmc-9.11-3.fc12.src.rpm 
> xbmc.src: W: no-cleaning-of-buildroot %clean
> 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> Only just noticed this warning after the upload: will fix in next iteration.

There are other majors issues I am aware about:

* the spyce stuff is outdated and breaks with python-2.6 (Earlier versions of
my spec failed to build in mock because of this - I have a patch, I grabbed
somewhere on the net.)

* parts of xbmc don't acknowledge RPM_OPT_FLAGS

* Lack of DESTDIR support.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.