[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=289


Erik van Pienbroek <erik-rpmfusion at vanpienbroek.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erik-
                   |                            |rpmfusion at vanpienbroek.nl
             Status|NEW                         |ASSIGNED




--- Comment #1 from Erik van Pienbroek <erik-rpmfusion at vanpienbroek.nl>  2009-01-01 19:38:44 ---
Some initial comments:

- Does this package still work with GStreamer 0.10 ? The website only mentions
support for GStreamer 0.8 and the CVS doesn't seem to have any activitity in
the last 10 months
- The rpmlint warning about the executable stack indicates this package will
conflict with SELinux. This is really something that should be looked into
- IIRC, this package only works on the i386 architecture. Thus the spec should
require an ExclusiveArch: i386
- This package is only useful in combination with win32 codecs. Are you (or
someone else) willing to package/maintain this for RPMFusion (non-free) ?
- Why do you perform an 'mkdir -p $RPM_BUILD_ROOT%{_libdir}/codecs/' in the
%install phase? It doesn't seem to have any purpose right now

Full review coming soon


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.