[Bug 289] Review request: gstreamer-pitfdll - GStreamer plugin for using MS Windows binary codecs

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=289





--- Comment #7 from Erik van Pienbroek <erik-rpmfusion at vanpienbroek.nl>  2009-01-04 15:05:31 ---
Here's the review:

Please add an extra comment to the description mentioning this plugin requires
external win32 codecs which can't be redistributed in RPMFusion due to legal
reasons and that these codecs need to be saved in the directory /usr/lib/codecs

---

While testing, I've found out you need to install the win32 codecs BEFORE
installing this plugin. If you don't, the win32 codecs won't be detected by
gstreamer:

$ gst-inspect pitfdll
Plugin Details:
  Name:                 pitfdll
  Description:          DLL-loader elements
  Filename:             /usr/lib/gstreamer-0.10/libpitfdll.so
  Version:              0.9.1.1
  License:              GPL
  Source module:        pitfdll
  Binary package:       PitfDLL
  Origin URL:           http://ronald.bitfreak.net/pitfdll/


  0 features:

If this plugin was installed while the win32 codecs weren't installed yet, you
can force a gstreamer recheck by removing the directory ~/.gstreamer-0.10 :

$ rm -rf ~/.gstreamer-0.10
$ gst-inspect-0.10 pitfdll
Plugin Details:
  Name:                 pitfdll
  Description:          DLL-loader elements
  Filename:             /usr/lib/gstreamer-0.10/libpitfdll.so
  Version:              0.9.1.1
  License:              GPL
  Source module:        pitfdll
  Binary package:       PitfDLL
  Origin URL:           http://ronald.bitfreak.net/pitfdll/

  qtadec_bin: quicktime binary audio decoder
  dmodec_wmspdmodv1: DMO wmspdmod decoder version 1
  dmodec_wmadmodv3: DMO wmadmod decoder version 3
  dmodec_wmadmodv2: DMO wmadmod decoder version 2
  dmodec_wmadmodv1: DMO wmadmod decoder version 1
  dmodec_wmvdmodv3: DMO wmvdmod decoder version 3
  dmodec_wmvdmodv2: DMO wmvdmod decoder version 2
  dmodec_wmvdmodv1: DMO wmvdmod decoder version 1
  dmodec_wmv9dmodv3: DMO wmv9dmod decoder version 3
  dshowdec_ir41_32v4: DS ir41_32 decoder version 4
  dshowdec_ir50_32v5: DS ir50_32 decoder version 5

  11 features:
  +-- 11 elements

Perhaps it is a good idea to add this information to the description to
avoid future (false) bug reports.

---

During the %install phase, the directory /usr/lib/codecs is generated, but
it isn't part of the %files list. I don't know if this directory should really
be owned by this package as it is also used by MPlayer and Xine. Can somebody
on the mailing list clarify whether two or more packages can own a directory?

---

This package only works on the i386 architecture (it doesn't even compile
on x86_64). Please add an 'ExclusiveArch: i386' to the .spec file

---

rpmlint has indicated that the plugin has an executable stack. This causes
issues with SELinux. To fix this, add the line ...

export LDFLAGS="-Wl,-znoexecstack"

... to the .spec file, right above the %configure line.

I haven't tested if this causes any breakage as I don't have any files
at hand which can only be decoded by the win32 codecs.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.