[Bug 303] Review request: Mupen64Plus - A Nintendo64 Emulator

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=303





--- Comment #6 from Juan Moreno <uncholowapo at gmail.com>  2009-01-05 12:27:31 ---
(In reply to comment #5)
> (In reply to comment #4)
> > The application already installs a .desktop file itself. I will take a look at
> > the mupen64 srpm.
> 
> If that is the case, you are not requiring the following dependencies:
> BuildRequires:  desktop-file-utils
> Requires:       hicolor-icon-theme
> 
> Moreover you are not using desktop-file-validate to validate file installed by
> makefile:
> https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor
> You will see another problem when you'll use desktop-file-validate.
> 
> This is wrong in %files:
> %{_datadir}/* 
> In this way the package will own a directory that belongs to another package:
> /usr/share/applications
> 
> This is wrong in %install:
> make install PREFIX=%{buildroot}/usr
> use macros:
> make install PREFIX=%{buildroot}/%{_prefix}
> 
> This is wrong in %files:
> /usr/man/man1/mupen64plus.1.gz
> The path you are providing is wrong. Man entries are not installed in /usr/man
> but in /usr/share/man. Moreover you must use macros, such as:
> %{_mandir}/man1/mupen64plus.1*
> 
> Therefore you will need to set some of the following variables when calling the
> makefile:
>      PREFIX=path   == install/uninstall prefix (default: /usr/local/)
>      SHAREDIR=path == path to install shared data (default:
> PREFIX/share/mupen64
> plus/)
>      BINDIR=path   == path to install mupen64plus binary (default: PREFIX/bin/)
>      LIBDIR=path   == path to install plugin libs (default: SHAREDIR/plugins/)
>      MANDIR=path   == path to install manual files (default: PREFIX/man/man1/)
> 
> Optsflags are not used when compiling.
> 
> Rpmlint is not silent:
> $ rpmlint /home/andrea/rpmbuild/RPMS/x86_64/Mupen64Plus-1.5-1.fc10.x86_64.rpm
> Mupen64Plus.x86_64: W: devel-file-in-non-devel-package
> /usr/share/mupen64plus/doc/Audio_1.1.h
> Mupen64Plus.x86_64: W: devel-file-in-non-devel-package
> /usr/share/mupen64plus/doc/Rsp_1.1.h
> Mupen64Plus.x86_64: W: devel-file-in-non-devel-package
> /usr/share/mupen64plus/doc/Audio_1.2.h
> Mupen64Plus.x86_64: W: devel-file-in-non-devel-package
> /usr/share/mupen64plus/doc/Input_1.1.h
> Mupen64Plus.x86_64: W: devel-file-in-non-devel-package
> /usr/share/mupen64plus/doc/Graphics_1.3.h
> Mupen64Plus.x86_64: E: explicit-lib-dependency libpng
> Mupen64Plus.x86_64: E: explicit-lib-dependency zlib
> Mupen64Plus.x86_64: W: incoherent-version-in-changelog 1.5 ['1.5-1.fc10',
> '1.5-1']
> Mupen64Plus.x86_64: W: executable-stack /usr/bin/mupen64plus
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/blight_input.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/dummyaudio.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/mupen64_input.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/ricevideo.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/jttl_audio.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/glide64.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/mupen64_hle_rsp_azimer.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/glN64.so
> Mupen64Plus.x86_64: E: arch-dependent-file-in-usr-share
> /usr/share/mupen64plus/plugins/dummyvideo.so
> Mupen64Plus.x86_64: W: non-standard-dir-in-usr man
> 1 packages and 0 specfiles checked; 11 errors, 8 warnings.
> 
> $ rpmlint
> /home/andrea/rpmbuild/RPMS/x86_64/Mupen64Plus-debuginfo-1.5-1.fc10.x86_64.rpm
> Mupen64Plus-debuginfo.x86_64: E: empty-debuginfo-package
> 
> Use rpmlint -i to have a description of the actions needed.
> 
> Can you host your files somewhere else than rapidshare? It is very frustrating
> to use.
> 

I will make the proper changes and report back. Can you suggest a hosting site?


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.