[Bug 308] Review request: ultrastardx - Karaoke game inspired by a popular commercial karaoke game

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=308





--- Comment #4 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-01-19 01:14:01 ---
You are quite welcome :)
Here is the last part of the review. I think this will cover everything
remaining:

! The tarball in the SRPM slightly differs from the snapshot I downloaded via
the fetch script. The fonts were not removed from the tarball in the SRPM but
the one I downloaded with the fetch script has them removed. But this is not a
blocker since you are not using/packaging them.

* Please preserve the timestamps of the non-compiled files. e.g. the
documentation files
   touch -r original_file modified_file

? You can use libprojectM_VERSION=$(pkg-config --modversion libprojectM)
instead of hard-coded libprojectM_VERSION='1.2.0'
I leave this up to you. (You don't have to BR:pkgconfig since it will be pulled
up by other BRs)

? There is a hard-coded path in ultrastardx-external-fonts.patch. You might
want to use sed and %{_datadir} instead of a patch (or patch+sed). Up to you.

* For the versioning, I think it is best to obey the guidelines:
  
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
See the second alsa-lib example (Upgrade Path Example (alsa-lib): )

Well, when you do this change you will get an rpmlint complaint. You will have
to cheat (modify the previous version in the changelog). I think it's ok. Don't
tell anyone :)


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.