[Bug 309] Review request: openttd - An open source reimplementation of the game "Transport Tycoon Deluxe"

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=309





--- Comment #12 from Andrea Musuruane <musuruan at gmail.com>  2009-01-22 18:34:11 ---
(In reply to comment #11)
> Sorry for having you all waiting so long.
> 
> Here are some new files:
> 
> SPEC: http://felix.fetzig.org/rpms/review/openttd.spec
> SRPM: http://felix.fetzig.org/rpms/review/openttd-0.6.3-3.fc10.src.rpm

* Rpmbuild failed when building with mock F9/i386.

* The makefile suppress the output when calling many commands including the
compiler. In this way neither the submitter nor the reviewer can see how the
files are complied, linked and so on.

Using %{optflags} is mandatory and with the unpatched upstream makefile there
is no way to check them:
https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

* macro style is not consistent. You should use either %{__make} or make. Not
mixing both syntaxes. I suggest you to use the latter because it is more
readable. I cannot think of a good reason to use the former.

A complete discussion about these case has been discussed in fedora-devel-list:
http://www.redhat.com/archives/fedora-devel-list/2008-December/msg01855.html

* The GTK+ icon cache scriptlets are not the same used in the guidelines:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache

* It seems to me that most of the documents in the docs directory are not aimed
at the Fedora end user and therefore they must not be included. 

I would package only these ones in that directory:
docs/Manual.txt
docs/multiplayer.txt

* changelog should be a faithful description of the changes. Entries like the
followings are not useful :(

- even more improvements made
[...]
- incorporated suggestions made by reviewers

(In reply to comment #9)
> However I think it's easier and probably nicer to distribute a own .desktop
> file if you take into account that I added a .desktop file for the server as
> well which is not offered by upstream. I think patching a file which alters say
> 7 of a 10 line file doesn't make that much sense. Also mangling through
> desktop-file-install doesn't seem to get me where I want.

I really cannot see why you cannot use the upstream desktop file for openttd.
The upstream desktop file seems OK to me. Even the categories can be adjusted
with a single parameter in the make invocation
(--menu-group="Game;Simulation;"). Moreover, Fedora mantra is upstream,
upstream and upstream.

* A question. Isn't the dedicated server redundant? The normal client can start
a dedicated server with the "-D" parameter. I understand it brings in less
dependency, but is it really worth the trouble?

When I can build it I'll continue my analysis.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.