[Bug 391] Review request: python-vlc - VLC Media Player binding for Python

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=391





--- Comment #13 from NicolasChauvet <kwizart at gmail.com>  2009-06-03 13:15:13 ---
(In reply to comment #12)
> Yes. vlcwidget.py can be used as a standalone script. i.e.
>    vlcwidget.py video_file.avi
> If I don't make it executable, rpmlint complains with something like
>    "non-executable script"
As the vlcwidget.py in sources is set executable, I would consider this as a
bug in distutils for not having preserved the permission. Having it chmoded is
the right thing then.
> In the previous version of my SRPM, I used to put vlcwidget.py into %{_bindir}.
> But now setup.py is installing the file in %{python_sitearch}, so I removed my
> manual installation to %{_bindir}.
That was decided by the upstream maintainer, I've made it notice that change.
But it is more intended to be imported from python.

I don't like at all this dirty hack :
echo "include COPYING" >> MANIFEST.in

Packager including a license is totally wrong, you don't have right to do that.
If you want a source archive to bundle a license, you can send a patch upstream
asking to do that. But you are not allowed to do that yourself.

What is mandatory according to the license Guideline is to have a "License:"
Field from within the spec file, not for the package to bundle a license,
specially if it's clear enough.
The only case when a license is mandatory is when a firmware (or other
component) needs to allow redistribution , because that needs to be explicitly
written.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.