[Bug 310] scid - A chess database application

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=310





--- Comment #14 from Mikhail Kalenkov <Mikhail.Kalenkov at gmail.com>  2009-06-08 13:14:19 ---
(In reply to comment #12)
Thank you for the review. I am very sorry for the delay in the answer. I was
really very busy.

SPEC: http://katrine.lpi.ru/kalenkov/fusion/scid.spec
SRPM: http://katrine.lpi.ru/kalenkov/fusion/scid-3.7.3-2.fc10.src.rpm

>    scid-books.x86_64: W: no-documentation
> books/readme.txt should be included as a %doc to this subpackage.
done

> * Patches should be explained (as comments in the SPEC file), and, if they are
> not Fedora specific, should be submitted upstream and the corresponding bug
> tracker links should be provided.
Patches are very short and very simple. I wrote short description in spec file.
Patches change some default paths and permissions. It is  useless to submit
corresponding bugs upstream, because it can be regarded as Fedora specific
(paths) or discussed several times in scid mailing list (permissions).

> * About the patches:
>    scid-makefile-engines.patch
>       - Please use the -p switch for "install" command to preserve timestamps. 
>         In general, we want to conserve the timestamps of all non-compiled 
>         files.
>       - You said bases/* is excluded by purpose, and upstream was working on 
>         them. Any updates on this latest release (3.7.1)?
Done. I packaged bases as a separate package, but actually scid cann't work
with this read only bases fluently.

>    scid-makefile-phalanx.patch
>       - We don't want this patch. Fedora requires it's own optflags. 
>         Please see:
>           http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
I dropped this patch.

> * Please preserve the timestamps of the files for which you fix the encoding.
> You can use 
>    touch -r original_file encoding_fixed_file
> for this purpose.
Done.

> ! Please make the %description span 80 columns.
??? The length of the longest line in description is 70 chars.

> ? The file engines/Phalanx-XXII/phalanx.h contains occurences of
> /usr/local/lib. Does this affect anything?
It works. 

> * All relevant doc files should be packaged. There are many documentation files
> scattered around the tarball. Can you go through them and include the relevant
> ones in %doc ?
What docs did you mean? It is not necessary to include scid/html/*.html files
because they are included into /usr/bin/scid file.

> 
> * Buildroot does not obey Fedora guidelines. Please see:
>    http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
> 
> * BR: gcc-c++ can be removed. Please see:
>    http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
> 
> * Requires: tk can be removed. rpmbuild will pick this dependency itself.
Done.

> ! We prefer installing the icons under %{_datadir}/icons/hicolor. So the
> %SOURCE3 file should go to %{_datadir}/icons/hicolor
> You will also need to take a look at the icon cache scriptlets after this
> change:
>    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
Done.

> * Each package must consistently use macros, as described in the macros section
> of Packaging Guidelines . You use %{name} at certain locations and scid on
> other. The former one is preferred (except, possibly in URL).
> 
> Also, if you want to use %{__mv}, %{__sed} style macros, do it for all the
> commands in the SPEC file, or just replace them with regular commands, e.g. mv,
> sed.
Done.

> ! The line 
>    --remove-category Application \
> is not needed since you already don't have Application as category in the
> .desktop file you supply. Even if you did, you should just remove it from the
> .desktop file yourself before compiling the SRPM.
Done.

> * Latest version must be packaged, which is 3.7.1 for the time being. Please
> update. Also make sure you check the bases/* issue.
Done.

> * Package does not honor Fedora specific optimization flags (see above). You
> can probably pass OPTIMIZE=%{optflags} to configure to overcome this. (I found
> this by issuing 
>    ./configure --help
Done.

> * Parallel make must be supported whenever possible. If it is not supported,
> this should be noted in the SPEC file as a comment. See:
>    http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2/paral
Done.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.