[Bug 436] Review request: moonlight - Moonlight is an open source implementation of Microsoft Silverlight for Unix systems

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=436





--- Comment #31 from Ismael Olea <ismael at olea.org>  2009-05-04 16:21:04 ---
(In reply to comment #29)

> Why are theses options not using the usual %configure macro ?
> %{?env_options}
> %{?configure_options}

I removed this.

> Why aren't you using a dist tag. Please use one. it definitely make sense to
> have a dist tag for binary package. (even for a noarch packages that was built
> using a special version of rpm)

I don't understand: I'm using it:

          «Release:        5%{?dist}

(Maybe I'd only forgot to update the spec at my website).

> About this:
> >rm %{buildroot}%{_libdir}/libmoon.so
> >rm %{buildroot}%{_libdir}/moon/plugin/*.la
> >rm -rf %{buildroot}%{_libdir}/pkgconfig
> * Why this symlink is deleted ?
> * You should probably use that to remove .la in subdirectory (if any).
> find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
> * Why are you removing pkgconfig ?

Because, as said, I'm building only Silverlight 1 support.

When v2 support be more stable I'll work on that and I'll add the needed devel
package too.

Updated files:

http://olea.org/tmp/moonlight.spec
http://olea.org/paquetes-rpm/mono/

Love to see this approved O:-D


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.