[Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=393


Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4
         AssignedTo|rpmfusion-package-          |paul at city-fan.org
                   |review at rpmfusion.org        |
             Status|ASSIGNED                    |NEW




--- Comment #6 from Paul Howarth <paul at city-fan.org>  2009-05-06 15:26:34 ---
rpmlint output:

perl-IP-Country.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
26)
perl-IP-Country-utils.noarch: W: spurious-executable-perm
/usr/share/doc/perl-IP-Country-utils-2.26/dbmScripts/whois_filenames
perl-IP-Country-utils.noarch: W: doc-file-dependency
/usr/share/doc/perl-IP-Country-utils-2.26/dbmScripts/whois_filenames /bin/bash
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

review items:

- rpmlint not clean; mixed-use-of-spaces-and-tabs is easy fix, other
  complaints can be ignored as it's reasonable to ship executable
  documentation and an additional dependency on /bin/bash is nothing to
  worry about
- package and spec file names are fine
- package meets packaging guidelines
- license is OK (same as perl), upstream matches package
- no distributed detached license file to include
- spec file written in English and is legible
- source tarball matches upstream for content and timestamp
- package builds successfully in mock for rawhide.x86_64
- buildreqs fine
- no locale data, shared or static libraries, devel files to worry about
- package not intended to be relocatable
- directory ownership is fine
- no duplicate files
- no permissions problems, %defattr present and correct
- %clean section present and correct
- %install section cleans buildroot properly too
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- not a GUI app, no desktop file needed
- no filename encoding problems
- package appears to function correctly
- no scriptlets
- subpackage dependency is fine
- only file dependencies are /bin/bash and /usr/bin/perl (OK)

TODO:

Fix spec to use spaces or tabs but not both, as per rpmlint complaint.
Feel free to do this after import.

I APPROVE perl-IP-Country-2.26-2


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.