[Bug 588] Review Request: rpmfusion-remixes-kickstarts -- Kickstart files for creating distributions or remixes with RPM Fusion packages

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=588


Robert Scheck <rpmfusion-bugzilla at linuxnetz.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3
             Status|NEW                         |ASSIGNED




--- Comment #4 from Robert Scheck <rpmfusion-bugzilla at linuxnetz.de>  2009-05-10 21:38:46 ---
- "URL: http://rpmfusion.org/spin-kickstarts" doesn't exist
- s/remixes/remix/ seems to make sense to me because of "spin" not "spins"
- You are aware about, that the licensing is not just done by putting a
  licensing file somewhere? At source code, the code itself e.g. needs to
  mention the licensing or another file such as readme has to clarify the
  overall licensing - as far as I got told by spot. Given that this here is
  only a bunch of configuration files, I'm seeing it relaxed, just as note.
- "License: GPLv2+" vs. shipping GPLv3 is legally okay, but is it intended?
- Files are put into %{_datadir}/%{name} currently, I assume you already
  have checked, whether there's maybe a common directory which not including
  the package name? Or was it intended to use %{name} rather something else?
- You might want to explain in a comment how the versioning works as you do
  not ship a tarball, just a few words (looks like you now depend on spin-
  kickstarts versioning?)


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.