[Bug 527] Review request: mlt - Toolkit for broadcasters, video editors, media players, transcoders

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=527





--- Comment #80 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-05-20 07:35:34 ---
Upon Zarko's personal request I had a look at this last version of the package.

- The license tag is fine. Some parts of the software is GPL, some part is
LGPL.

* The segfault on F-10 persists (just run /usr/bin/mlt)

* There are these undefined symbols that need attention:
   $ ldd -r `rpm -ql mlt|grep so$`|grep undefined
   undefined symbol: sqrt  (/usr/lib64/mlt/libmltmotion_est.so)
   undefined symbol: floor (/usr/lib64/mlt/libmltmotion_est.so)
So -lm needs to be passed to the linker for this .so file.

* I am not able to make builds on ppc/ppc64. I see this
   #if defined (ARCH_PPC) && defined (ENABLE_ALTIVEC)
on src/modules/xine/cpu_accel.c but I don't see where the ARCH_PPC and
ENABLE_ALTIVEC are defined. It might be good to make use of altivec in these
architectures for better performance. Maybe you need to pass an extra
"-DARCH_PPC -DENABLE_ALTIVEC" to the compiler on ppc/ppc64? Please ask upstream
about this (why they don't define ARCH_PPC and ENABLE_ALTIVEC anywhere).

* The file /usr/include/mlt++/config.h from mlt-devel has the weird mixed
license clause. If the actual license of this file is LGPL and the demo/
directory is LGPL, then the devel subpackage will be just LGPL. This needs
clarified.

The rest seems fine.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.