[Bug 479] Review Request: xmms-mplayer - MPlayer plugin for XMMS

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=479


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4




--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-05-21 19:37:42 ---
(In reply to comment #5)
> Thanks for the review!
> 
> (In reply to comment #4)
> > NEEDSWORK
> > - I can't find a single mention of a license in the tarball, webpage states 
> > its contents is licensed under GPL. Please contact author to get license 
> > headers in source code.
> > 
> 
> There is a COPYING file that contains the GPL text. I also sent an email
> upstream with the request of adding license info to source headers but I doubt
> that this will be taken into consideration as the project is pretty much dead
> (No activity for 5+ years).

Right, hadn't noticed that. Well, according to

https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

the COPYING file included is the last resort; if it's a GPL copying then
license tag should be set to GPL+, so that's OK.

> > NEEDSWORK
> > - Add explicit Requires: xmms-libs for dir ownership. (Although this is 
> > pulled in by xmms's requirement on libxmms.so.1)
> > 
> 
> This is totally unnecessary. xmms is a very well established old package. It
> will always depend on xmms-libs. I'd like to keep BR's and R's minimal.

Well, I'm not quite sure how to read the guidelines on this one.

The end result is that the package requires the libs package due to the .so
dependency, and since the xmms is very old this is probably OK.


The package has been

APPROVED


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.