[Bug 396] Review request: paintdotnet - A mono port of the Paint.NET image editor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=396


Orcan Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |3
         AssignedTo|rpmfusion-package-          |oget.fedora at gmail.com
                   |review at rpmfusion.org        |




--- Comment #21 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-05-22 04:45:01 ---
As it seems, no one wants to deal with recreating the artwork, so we will have
this package here at rpmfusion.

* rpmlint says
   paintdotnet.src: W: invalid-license CC-BY-NC-ND
   paintdotnet-debuginfo.x86_64: W: invalid-license CC-BY-NC-ND
   paintdotnet-devel.x86_64: W: invalid-license CC-BY-NC-ND
   paintdotnet.x86_64: W: invalid-license CC-BY-NC-ND
   paintdotnet.x86_64: E: no-binary
   paintdotnet.x86_64: W: only-non-binary-in-usr-lib
These can be ignored. However
   paintdotnet-debuginfo.x86_64: E: empty-debuginfo-package
Please disable the debuginfo package.

! Remember that mono is not available on ppc64 for Fedora < 11. So if you want
to build paintdotnet on Fedora < 11 you will need to use an ExcludeArch.

! Please explain in the SPEC file as a comment what is MIT, what is
CC-BY-NC-ND.

* Why does the main package require pkgconfig? Do you mean it for the devel
package?

! Please use the %{name} macro consistently.

! BR: mono-winforms seems unnecessary. Package builds without it.

* It looks like the main package needs to require hicolor-icon-theme for
directory ownership.

? You are supplying an external .desktop file. That's okay. But why are you
using "--add-category X-Red-Hat-Extra"? You can manually add this to the
.desktop file.

* Packages shall not contain duplicate files. Please remove 
   %doc Resources/Files/License.txt Resources/Files/AboutCredits.rtf
from the devel package.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.