[Bug 616] Review request: thunderbird-enigmail - Enigmail extension for Mozilla Thunderbird

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=616


Thorsten Leemhuis <fedora at leemhuis.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4




--- Comment #12 from Thorsten Leemhuis <fedora at leemhuis.info>  2009-05-22 18:16:50 ---
(In reply to comment #11)
> SPEC: http://rpms.famillecollet.com/SPEC/thunderbird-enigmail.spec
> SRPM:
> http://rpms.famillecollet.com/SRPMS/thunderbird-enigmail-0.96a-0.3.cvs20090521.fc11.remi.src.rpm

- Please add a note to the comments regarding the CVS checkout that mentions
the login password is "guest"

- rpmlint:

thunderbird-enigmail.src: W: strange-permission thunderbird-mozconfig-branded
0755
thunderbird-enigmail.src: W: strange-permission enigmail-fixlang.php 0755
thunderbird-enigmail.src: W: strange-permission mozilla-extension-update.sh
0755
thunderbird-enigmail.src:214: W: non-break-space line 214
thunderbird-enigmail.src:219: W: non-break-space line 219
thunderbird-enigmail.src:231: W: non-break-space line 231
thunderbird-enigmail.src:234: W: non-break-space line 234
thunderbird-enigmail.src:240: W: non-break-space line 240
thunderbird-enigmail.x86_64: W: no-documentation
thunderbird-enigmail-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/thunderbird-enigmail-0.96a/objdir-tb/mozilla/dist/include/string/nsAlgorithm.h
3 packages and 0 specfiles checked; 0 errors, 10 warnings.

I don't consider any of those to be a hard blocker, but some of the warnings
afaics can get avoided easily which would be "nice to have"/can't hurt ;-)

- the spec file is a bit odd in some place, but that's not really avoidable
afaics. 

APPROVED


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.