[Bug 529] Review request: kdenlive - Non-linear video editor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=529


Orcan Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oget.fedora at gmail.com
             Blocks|2                           |3
         AssignedTo|rpmfusion-package-          |oget.fedora at gmail.com
                   |review at rpmfusion.org        |




--- Comment #15 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-05-22 20:39:32 ---
Here are my notes for this package:

- rpmlint is silent

! Please make the description span 80 columns

! effects/README can go to %doc

* BuildRequires:  mlt++-devel must be removed

* Also these BR's seem unnecessary to me. Package builds without them:
   BuildRequires:  qt-devel
   BuildRequires:  kdemultimedia-devel
   BuildRequires:  kdebase-devel
   BuildRequires:  kdebindings-devel

* I don't think that we need this explicit Requires:
   Requires:       kdebase-runtime

* The file src/initeffects.cpp contains references to
    "/usr/lib/ladspa"
    "/usr/local/lib/ladspa"
These should be sed'ed or patched to work on 64bit systems

! I think the license should be just GPLv2+. The only LGPL bit is
src/regiongrabber* and these get compiled into a final binary together with GPL
stuff, and hence making the package GPL.

* Afaict, the package does not install anything in the dynamic linker's default
paths. So you don't need to call /sbin/ldconfig in %post and %postun.

* Each package must consistently use macros, as described in the macros section
of Packaging Guidelines. Please use the %{name} macro consistently.

* We prefer %defattr(-,root,root,-)

* Fedora specific optflags are not honored. Please fix this. Ref:
http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
You can see the Fedora specific optflags via
   rpm -E %optflags

! desktop-file-validate should go to %check

* desktop entry has a MimeType key. So we must obey the scriptlets guideline:
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.