[Bug 436] Review request: moonlight - Moonlight is an open source implementation of Microsoft Silverlight for Unix systems

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=436


Orcan Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oget.fedora at gmail.com




--- Comment #40 from Orcan Ogetbil <oget.fedora at gmail.com>  2009-05-31 18:30:51 ---
Here are some preliminary notes. There is a lot of work that needs to be done.

! The moonlight in Fedora 11 is compiled with --enable-moonlight=yes. So you
may want to enable the "with_managed" for Fedora > 11.
When I changed with_managed to yes, I got 
   Bad build req: No Package Found for rsvg2-sharp. Exiting.
on Fedora 11. What's wrong?

* The %doc for all subpackages are the same, which results in duplicate files.
Please list those files in the appropriate package only.

* Please fix the rpmlints
   moonlight-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mopen1
['/usr/lib64']
   moonlight-plugin.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/moon/plugin/libmoonplugin.so ['/usr/lib64']
   moonlight.src: E: invalid-spec-name

* Please remove the src/zip, cairo and pixman directories in %prep. We don't
need them, we don't want them. You should use Fedora's minizip instead of
src/zip

* Additionally the files and directories
   ./plugin/TODO: ASCII English text 
   ./plugin/ChangeLog: ASCII English text
   ./plugin/firefox/ff2/ChangeLog: ASCII English text
   ./plugin/firefox/ChangeLog: ASCII English text  
   ./plugin/firefox/ff3/ChangeLog: ASCII English text 
   ./plugin/samples/: directory
   ./LICENSE: ASCII English text
   ./tools/mxap/ChangeLog: ASCII English text  
   ./tools/mopen/ChangeLog: ASCII English text 
   ./tools/xaml2html/ChangeLog: ASCII English text
   ./tools/README: ASCII English text
   ./NOTES: ASCII English text
   ./gtk/docs/: directory
   ./gtk/ChangeLog: ASCII English text
   ./examples/desklet/glassyclock/ChangeLog: ASCII text
   ./examples/desklet/cpumonitor/ChangeLog: ASCII text
   ./examples/desklet/glassyslides/ChangeLog: ASCII text
   ./examples/desklet/simpleclock/ChangeLog: ASCII text
   ./examples/desklet/glassymonitor/ChangeLog: ASCII English text
   ./examples/desklet/calculator/ChangeLog: ASCII English text
   ./examples/desklet/README: ASCII English text
should probably go to appropriate %docs.

? Any reason why you are not touching/packaging the perf/ directory?

? What are those binary .pub and .snk files?

? Why is the package named "moonlight" and not just "moon"? What do other
distros do?

* The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines.

* The file LICENSE indicates different licenses for different parts. Please use
the appropriate license(s) for each package

* Source should be given in full URL, with appropriate macros.

* We prefer %defattr(-,root,root,-)

* Be careful about directory ownerships. For instance the tools package has
   %{_libdir}/moon/mopen.exe*
where the directory %{_libdir}/moon/ is owned by the plugin package. But the
tools package does not require the plugin package, leaving %{_libdir}/moon/
unowned in case the plugin package is not installed. There are many other
similar issues. Please check every file one by one.


Please address the above issues so we can proceed with the review.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.