[Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155


Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4




--- Comment #2 from Rex Dieter <rdieter at math.unl.edu>  2010-04-12 18:01:49 ---
source confirmed,
md5sum *.gz
876bb0d57e218bfd76ca77b5abba813b  ffmpegthumbnailer-2.0.0.tar.gz


1.  SHOULD move %{_includedir}/libffmpegthumbnailer dir ownership to -devel pkg

2.  SHOULD move
chmod -x README INSTALL COPYING AUTHORS
to %prep section (not %build)

3.  SHOULD remove
%doc README INSTALL COPYING AUTHORS
from -devel, no need to duplicate this from the main pkg.  While you're at it,
no need to %doc INSTALL at all really.

4.  SHOULD checked the code, it all contains the "or later" clause, so can use
License: GPLv2+

scriptlets: ok

naming: ok

macros: ok, though you can drop
%{?_kde4_macros_api:Requires: kde4-macros(api) = %{_kde4_macros_api} }
none of the _kde4_* macros are used anywhere in this package that I can see.

5. SHOULD track lib sonames closer, currently %files contains,
%{_libdir}/*.so.*
and
%{_libdir}/*.so (-devel)
I'd suggest using
%{_libdir}/libffmpegthumbnailer.so.4*
%{_libdir}/libffmpegthumbnailer.so
respectively instead, to better highlight future ABI breaks.


I don't consider any of these SHOULD items review blockers, but please consider
addressing them before making any package releases.


APPROVED.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.