[Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155


NicolasChauvet <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kwizart at gmail.com




--- Comment #6 from NicolasChauvet <kwizart at gmail.com>  2010-04-15 11:22:56 ---
(In reply to comment #4)
> I just noticed this,
...
> Name: libffmpegthumbnailer
> Description: Generates thumbnails for movie files
> Version: 2.0.0
> Libs: -L${libdir} -lffmpegthumbnailer
> Cflags: -I${includedir}
> 
> This should be patched to be something like this instead:
> Libs: -L${libdir} -lffmpegthumbnailer
> Libs.private: -lavutil -lavformat -lavcodec -lswscale   -lpng12   -ljpeg

Why would you like to hardcode Libs.private dependencies while we do not use
static linking ? That's pointless for us, but if one to make things right. You
need to use the @FFMPEG_LIBS@ flags that was actually used at compilation time.
(or to uses Requires.private: the_right_ffmpeg.pc , but this one will indeed
bring undeeded ffmpeg-devel CFLAGS in libffmpegthumbnailer_CFLAGS also when
using building shared).

Please ask upstream to review this change ASAP.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.