[Bug 1157] Review request: kffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1157





--- Comment #3 from Magnus Tuominen <magnus.tuominen at gmail.com>  2010-04-17 12:35:55 ---
(In reply to comment #2)
> 1. SHOULD:
> License: GPLv2+
> 
> 2. SHOULD omit INSTALL from packaging
> 
> 3.  SHOULD omit
> Requires: ffmpegthumbnailer
> as it is already linked implicitly.
> 
> 4.  SHOULD add
> Requires: kdebase-workspace
> (ie, this isn't all that useful without kdebase-workspace.  :)  )
> 
> sources verified,
> $ md5sum *.gz
> fa897450ee691b6d225d8f79a6cfd409  kffmpegthumbnailer-1.1.0.tar.gz
> 
> naming: ok
> 
> macros: ok
> 
> %files: ok
> 
> 
> I don't consider any of these SHOULD items review blockers, but please consider
> addressing them before making any package releases.
> 
> Otherwise, this one is relatively simple and small,
> APPROVED.
> 
issues fixed.

http://magnu5.fedorapeople.org/review/kffmpegthumbnailer/SPEC/kffmpegthumbnailer.spec
http://magnu5.fedorapeople.org/review/kffmpegthumbnailer/SRPM/kffmpegthumbnailer-1.1.0-2.fc12.src.rpm


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.