[Bug 1171] Review request: rtmpdump - Toolkit for RTMP streams

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1171





--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2010-04-19 18:17:41 ---
rpmlint output:

rtmpdump.src: W: spelling-error %description -l en_US rtmp -> ramp, romp, rump
rtmpdump.src: W: spelling-error %description -l en_US rtmpt -> prompt, rampart,
tempt
rtmpdump.src: W: spelling-error %description -l en_US rtmpe -> romper, temper,
tamper
rtmpdump.src: W: spelling-error %description -l en_US rtmpte -> tempter,
prompter, prompted
rtmpdump.src: W: spelling-error %description -l en_US rtmps -> ramps, romps,
rumps
rtmpdump.x86_64: W: spelling-error %description -l en_US rtmp -> ramp, romp,
rump
rtmpdump.x86_64: W: spelling-error %description -l en_US rtmpt -> prompt,
rampart, tempt
rtmpdump.x86_64: W: spelling-error %description -l en_US rtmpe -> romper,
temper, tamper
rtmpdump.x86_64: W: spelling-error %description -l en_US rtmpte -> tempter,
prompter, prompted
rtmpdump.x86_64: W: spelling-error %description -l en_US rtmps -> ramps, romps,
rumps
3 packages and 0 specfiles checked; 0 errors, 10 warnings.


These are OK.

***

Drop SOURCE1, it's functionally identical to the original makefile.

***

MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A

MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A

MUST: A package must own all directories that it creates or require the package
that owns the directory. ~OK
- Please change
 %{_mandir}/*/*
to
 %{_mandir}/man1/rtmpdump.1.*
 %{_mandir}/man8/rtmpgw.8.*

MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK


APPROVED


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.