[Bug 1024] Review request: pushover - Fun puzzle game with dominos

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1024


Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org




--- Comment #1 from Xavier Bachelot <xavier at bachelot.org>  2010-01-04 12:25:15 ---
I'll review it, if no one is faster than me. I packaged the 0.0.1 version some
weeks ago, but didn't submit it because of the artwork issue. The 0.0.2 version
is starting to fix this.
>From a cursory glance, the spec looks clean.The only rpmlint warning about the
dangling symlink is fine.
Some preliminary notes, comparing with my own spec :
- You set the license to GPLv3 while I set it to GPLv3+ in my own package. I'll
check which of us is right.
- Typo in a comment (# Fix char encondig)
- I removed the whole $RPM_BUILD_ROOT%{_docdir}/pushover rather than just the
readme.txt file, as it was the only file in it. Not sure this is still true for
0.0.2, but anyway, it's better to have all files in
%{_docdir}/pushover-%{version}.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.