[Bug 1030] Review request: xbmc - Media center

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1030





--- Comment #72 from Alex Lancaster <alexl at users.sourceforge.net>  2010-01-25 07:13:45 ---
(In reply to comment #48)

> > This patch look for libdca, rather than libdts, there is already:
> >  http://xbmc.org/trac/ticket/8040 (although patch slightly different to this
> > one)
> >  Patch2: xbmc-9.11-b1-config.patch
> I renamed it to xbmc-9.11-libdca.patch. I tried the upstream patch, but it
> somehow makes make fail on "make -C libdts".

OK, ideally (from upstream POV) it this would detect either libdca or libdts
and choose the relevant one.

> > Rolf, is this necessary if we remove dvdcss from source?
> >  Patch3: xbmc-9.11-b1-dvdlibs-external.patch
> Without this patch configure fails in an attempt to descend to
> xbmc/cores/dvdplayer/Codecs/libdvd/libdvdcss and
> xbmc/cores/dvdplayer/Codecs/libdvd/libdvdread which no longer exist.

OK, that seems to just remove the directories from the build, so this doesn't
really work for upstream because they need to be able to build those directory
if the external library support is disabled.  Would it be possible to enhance
that patch.

> The purposes of the previous patches have been clarified by Ralf
> >  Patch10: xbmc-9.11-remlibs.patch
> Without this patch config.status attempts to descend to open
> xbmc/lib/libass/xbmc/Makefile.in which is obsolete (and has been removed) as
> we use external libass now. I renamed it to xbmc-9.11-remlibass.patch, and
> removed an irrelevant part.

OK, that's good but has the same problem as above: i.e. it can't be applied to
trunk because it needs to be able to work in internal and external mode.

I'll probably hold off on submitting these two patches upstream until they can
be made to work in non-external mode as well.

> I changed Source0 to be based on xz compression, it reduces the src.rpm size!
> 
> Both src.rpm and nosrc.rpm can be found at:
> http://rolffokkens.dyndns.org/xbmc-9.11-9.fc12/

Great thanks!  That's very helpful.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.