[Bug 1278] Review Request: mpg123 - MPEG audio player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1278


NicolasChauvet <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #15 from NicolasChauvet <kwizart at gmail.com>  2010-07-14 10:58:11 ---
>From what was already said:
1/ Either libmpeg123 or mpg123-libs is a matter of convention to me.
>From fedora guideline, the name of the package is the name of the source
tarball, then usually libraries targetted for multilibs subpackage has -libs
suffix. Now using lib has a prefix for mpeg123 when dealing with library is a
debian guideline. What should be keepted in mind, is that projects often change
to this namespace then. This seems the case here but only in wording, not as
source archive yet.
In this case, it only matter not to conflicts with an already existant package.
(as we already have libmpeg2 libmpeg3 mpeg4ip libmpg4v2 etc).

2/ alternatives. As of #c2 since mpg123 and mpg321 aren't option compatible
anymore, alternative could be dropped. Now maybe an mpg321 update will restore
this compatibility later. As I previously pushed for the mpg321 to support
alternatives, I think it's good to keep.

3/ audio output. What annoy me the most is to have the jack audio output at the
same level as deprecated output such as nas or esd. vlc has removed the code
for theses output since about 2 development cycle (including arts). So maybe we
shoudn't build them anymore. Using extras in this case is the right thing but
we shoudn't mix extras as 'less used plugins' and 'plugin for distro from the
last century'.

Now I understand the viewpoint of using pulseaudio output by default, I pushed
this way for a desktop music app reviewed here. But things aren't the same in
console mode. (and that's what I've done for the vlc case where the PA output
is removed from vlc-core to leave with vlc which brings desktop modules).
There is also a hight dependency footprint bring by the PA output.

So my advice is to split the pulseaudio and jack output to separate plugin, and
to have them added conditionally in comps.xml when the pa-libs or the jack
package is available.

Runtime test is following...


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.