[Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=794


Michel Alexandre Salim <Michael.Silvanus at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |4




--- Comment #15 from Michel Alexandre Salim <Michael.Silvanus at gmail.com>  2010-06-18 21:24:01 ---
Apart from the version/release number concern, the package is good to go. I'll
let you sort it out with upstream -- no reason to delay this package.

APPROVED.

* DONE Review [100%]
** DONE Names [2/2]
*** DONE Package name
*** DONE Spec name
** DONE source files match upstream
** DONE License [2/2]
*** DONE License field accurate
*** DONE License included iff packaged by upstream
** DONE rpmlint [2/2]
*** DONE on src.rpm
$ rpmlint ./r5u87x-firmware-0.2.0-3.a9b2171d762b.fc11.src.rpm 
r5u87x-firmware.src: W: spelling-error %description -l en_US chipsets -> chip
sets, chip-sets, chippers
r5u87x-firmware.src: W: spelling-error %description -l en_US uvcvideo ->
videodisc, videotex, videotape
r5u87x-firmware.src: W: spelling-error %description -l en_US udev -> udder,
rude, Devi
r5u87x-firmware.src: W: invalid-license Distributable
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

*** DONE on x86_64.rpm
$ rpmlint ~/Downloads/r5u87x-firmware-*
r5u87x-firmware.x86_64: W: spelling-error %description -l en_US chipsets ->
chip sets, chip-sets, chippers
r5u87x-firmware.x86_64: W: spelling-error %description -l en_US uvcvideo ->
videodisc, videotex, videotape
r5u87x-firmware.x86_64: W: spelling-error %description -l en_US udev -> udder,
rude, Devi
r5u87x-firmware.x86_64: W: invalid-license Distributable
r5u87x-firmware.x86_64: W: no-manual-page-for-binary r5u87x-loader
r5u87x-firmware-debuginfo.x86_64: W: invalid-license Distributable
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

** DONE Language & locale [3/3]
*** DONE Spec in US English
*** DONE Spec legible
*** N/A Use %find_lang to handle locale files
** DONE Build [3/3]
*** DONE Koji results
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2258372
*** DONE BRs complete
*** DONE Directory ownership
** DONE Spec inspection [8/8]
*** N/A ldconfig for libraries
*** DONE No duplicate files
*** DONE File permissions
*** DONE Filenames must be UTF-8
*** DONE Has %clean section
    (except F-13+:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)
*** DONE %buildroot cleaned on %install
*** DONE Macro usage consistent
*** DONE Documentation [2/2]
**** N/A If large docs, separate -doc
**** DONE %doc files are non-essential


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.