[Bug 993] Review request: openshot - GNOME Non-linear video editor

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=993


Mohamed El Morabity <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pikachu.2014 at gmail.com




--- Comment #19 from Mohamed El Morabity <pikachu.2014 at gmail.com>  2010-06-23 03:41:31 ---
(In reply to comment #18)
> Ok, line 44 is giving me hell. I'm on a 64bit system so it's resolving to:
> BUILDROOT/openshot-1.1.3-1.fc13.x86_64/usr/lib 
> 
> and the package only generates: 
> BUILDROOT/openshot-1.1.3-1.fc13.x86_64/usr/lib
> 
> help! ;)

Hi,

Modify this line like this:
   rm %{buildroot}/%{_prefix}/lib/mime/packages/openshot
since this useless file is installed in /usr/lib/mime/packages whatever the
architecture.


By the way:
- openshot calls melt from mlt, but RPM Fusion package mlt provides it renamed
as mlt-melt (probably to avoid conflicts with the melt executable provided by
freeze package). You should patch the source code to call mlt-melt instead of
melt (see the attached patch).

- be careful not to list locale files twice: since they are installed in
%{python_sitelib}/%{name}/locale (thanks to %{name}.lang), you should modify
your %files section like this:

%files -f %{name}.lang
%defattr(-,root,root,-)
%doc README COPYING AUTHORS 
%{_bindir}/*
%{_datadir}/applications/%{name}.desktop
%{_datadir}/pixmaps/*
%{_datadir}/mime/packages/*
%dir %{python_sitelib}/%{name}
%{python_sitelib}/%{name}/*.py*
%{python_sitelib}/%{name}/classes
%{python_sitelib}/%{name}/effects
%{python_sitelib}/%{name}/export_presets
%{python_sitelib}/%{name}/images
%{python_sitelib}/%{name}/language
%{python_sitelib}/%{name}/profiles
%{python_sitelib}/%{name}/themes
%{python_sitelib}/%{name}/titles
%{python_sitelib}/%{name}/transitions
%{python_sitelib}/%{name}/windows
%{python_sitelib}/*egg-info
%{_mandir}/man*/*

  .po files are also installed by default although they are useless, you shoud
remove them in %install.

- please add also the following missing Requires:
pyxdg
pygtk2-libglade
notify-python


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.