[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1034


Chen Lei <supercyper at 163.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |supercyper at 163.com




--- Comment #4 from Chen Lei <supercyper at 163.com>  2010-03-05 15:31:12 ---
(In reply to comment #0)
> Spec URL: http://rpms.infoglobe.ca/packages/sinthgunt.spec
> SRPM URL: http://rpms.infoglobe.ca/packages/sinthgunt-2.0.2-1.fc12.src.rpm
> Description: 
> Sinthgunt is an open source graphical user interface for ffmpeg, a computer
> program that can convert digital audio and video into numerous formats.
> Using pre-configured conversion settings, it makes the task of converting
> between different media formates very easy.
> This package is not eligible in Fedora because it depends on ffmpeg from
> rpmfusion-free repository.
> $ rpmlint -v SPECS/sinthgunt.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> $ rpmlint -v SRPMS/sinthgunt-2.0.2-1.fc12.src.rpm 
> sinthgunt.src: I: checking
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> $ rpmlint -v RPMS/noarch/sinthgunt-2.0.2-1.fc12.noarch.rpm 
> sinthgunt.noarch: I: checking
> sinthgunt.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/Sinthgunt/app.py 0644 /usr/bin/python
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
You need remove shebang from this file if it is unexecutable or add exec
permission for it on the contrary. 

Remove shebang from files 
There are several ways to remove a shebang from a file 

sed -i -e '/^#!\//, 1d' %{buildroot}%{sugaractivitydir}Test.activity/*.pyIf you
have several files, you can do: 

for Files in demo.py utils.py __init__.py test.py; do
  %{__sed} -i.orig -e 1d ${Files}
  touch -r ${Files}.orig ${Files}
  %{__rm} ${Files}.orig
done

Exec permission 
If rpmlint rightly complains about permission, you may have to set those. 

chmod a+x %{buildroot}%{sugaractivitydir}Analyze.activity/analyze.pyIf you have
more than one file 

for file in
%{buildroot}%{python_sitelib}/Onboard/{settings,settings-dialog,Keyboard,utils}.py;
do
   chmod a+x $file
doneor 

chmod a+x
%{buildroot}%{python_sitelib}/Onboard/{settings,settings-dialog,Keyboard,utils}.py


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.