[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036

Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2                           |3
         AssignedTo|rpmfusion-package-review at rp |hobbes1069 at gmail.com
                   |mfusion.org                 |

--- Comment #6 from Richard <hobbes1069 at gmail.com> 2011-12-09 23:20:32 CET ---
Ok, quick spec review first.

1. You don't need the "-n chromaprint-tools" since it's the name of the
package. You'll still need -n on %setup though since directory in the archive
doesn't include "tools" in the name". 

Speaking of which, I noticed you're deleting a lot of stuff in the spec. Is
there a reason for this?

2. Don't use macro versions of basic shell tools, in this case "rm". It's not
necessary and just hurts readability.

3. Unless you're going to build for EL5 (unlikely) you can get rid of:
BuildRoot:
%{__rm} -rf %{buildroot} in %install
%clean entirely
%defattr(-,root,root,-) in %files

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.