[Bug 585] Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=585





--- Comment #29 from Robert Scheck <rpmfusion-bugzilla at linuxnetz.de>  2011-06-07 01:10:44 ---
Spec URL: http://labs.linuxnetz.de/bugzilla/z-push.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/z-push-1.5.3-1.src.rpm

This is a new release of Z-Push, which also should solve the raised valid
concerns by Thorsten.

(In reply to comment #28)
>  * I for one find the spec file line
> License:        AGPLv3 with exceptions
>  confusing, as the "with exceptions" is not explained anywhere in an obvious
> place. I'd say a clarifying comment or section in the README.FEDORA.package
> would be a good idea. Normally I'd say you should bug upstream to add it to
> LICENSE or create a file LICENSE.exception instead of adding it to files like
> index.php only, as people might not see it there and think it's a regular
> AGPLv3

Good catch! I opened a bug in upstream tracker and in the meantime the issue
got fixed in upstream SVN. Until the next release I'm shipping a patch within
the z-push package. More details are within the *.patch file.

>  * BTW, I'd give files like README.FEDORA.package a prefix with %{name} in the
> SRPM, as otherwise bad things bappen when people install multiple SRPMs that
> contain files with that name

Fixed. I added the prefix "%{name}-" to remaining SourceX files.

>  * rpmlint gives a warning on the SRPM:
> z-push.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 3)

Fixed as well.

>  * should zarafa-z-push have a dep on zarafa or something else that owns
> /etc/zarafa/?

Another good catch! I added ownership of /etc/zarafa/ to zarafa-z-push, as I
think, section "The directory is owned by a package which is not required for 
your package to function" from the Fedora Packaging Guidelines
http://fedoraproject.org/wiki/PackagingGuidelines#File_and_Directory_Ownership
should apply here. And yes, I spent some time whether a -filesystem subpackage
makes sense or not, but for now it doesn't make sense, because z-push is the
only exception. Once this changes (which is very unlikely), I'll introduce of
course a -filesystem subpackage.


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.