[Bug 1829] Review request: deadbeef-0.5.1 - A music player with *.cue support

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1829


Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org




--- Comment #1 from Xavier Bachelot <xavier at bachelot.org>  2011-06-30 00:46:35 ---
I'm not a sponsor but I can try to help with the first steps of the review. RPM
Fusion packages are subject to the same packaging guidelines as Fedora, so
please make sure to take a look at them. It'll explain a lot of what you need
to do with the below rpmlint warnings.
https://fedoraproject.org/wiki/Packaging:Guidelines

> rpmlint deadbeef-0.5.1-1.fc15.i686.rpm
>
rpmlint should be run on the SRPM too. This will list some more things to fix
in the spec, but let's start with what you listed first.
https://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint

> deadbeef.i686: E: explicit-lib-dependency alsa-lib
> deadbeef.i686: E: explicit-lib-dependency imlib2
> deadbeef.i686: E: explicit-lib-dependency libX11
> deadbeef.i686: E: explicit-lib-dependency libcddb
> deadbeef.i686: E: explicit-lib-dependency libcdio
> deadbeef.i686: E: explicit-lib-dependency libcurl
> deadbeef.i686: E: explicit-lib-dependency libmad
> deadbeef.i686: E: explicit-lib-dependency libmms
> deadbeef.i686: E: explicit-lib-dependency libogg
> deadbeef.i686: E: explicit-lib-dependency libsamplerate
> deadbeef.i686: E: explicit-lib-dependency libsndfile
> deadbeef.i686: E: explicit-lib-dependency libvorbis
> deadbeef.i686: E: explicit-lib-dependency libzip
> deadbeef.i686: E: explicit-lib-dependency pulseaudio-libs
> deadbeef.i686: E: explicit-lib-dependency zlib

You don't need to require the libs, they will be autodetected at build time and
the proper requires added automatically. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

> deadbeef.i686: E: description-line-too-long C (though now it also runs in plain
> console without X, in FreeBSD, and in OpenSolaris).
> deadbeef.i686: E: description-line-too-long C It is mainly written by Alexey
> Yakovenko, with contributions from a lot of different people

The lines in the description should not have more than 80 characters. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

> deadbeef.i686: W: incoherent-version-in-changelog Yakovenko ['0.5.1-1.fc15',
> '0.5.1-1']

Please add the version and release to all changelog entries.
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/sndfile.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/supereq.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/wavpack.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vfs_zip.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vorbis.a
> deadbeef.i686: W: devel-file-in-non-devel-package
> /usr/lib/deadbeef/ddb_gui_GTK2.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/pulse.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/musepack.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/mms.a
> deadbeef.i686: W: devel-file-in-non-devel-package
> /usr/lib/deadbeef/dsp_libsrc.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/ffmpeg.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/tta.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/converter.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/hotkeys.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/flac.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/cdda.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/adplug.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vtx.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/lastfm.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/nullout.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/alsa.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/mpgmad.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/oss.a
> deadbeef.i686: W: devel-file-in-non-devel-package
> /usr/include/deadbeef/deadbeef.h
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/notify.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/artwork.a
> deadbeef.i686: W: devel-file-in-non-devel-package
> /usr/include/deadbeef/gtkui_api.h
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/gme.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/dca.a
> deadbeef.i686: W: devel-file-in-non-devel-package
> /usr/lib/deadbeef/converter_gtkui.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/vfs_curl.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/ffap.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/shellexec.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/wildmidi.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/aac.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/sid.a
> deadbeef.i686: W: devel-file-in-non-devel-package /usr/lib/deadbeef/m3u.a

You should not package static files. Even better, you should not even build
them. so either delete them or add --disable-static to the configure
invocation.
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries

> deadbeef.i686: W: no-manual-page-for-binary deadbeef

Harmless, but as it seems you are upstream, you can probably easily add a man
page.

> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/be/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/bg/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/bn/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/ca/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/da/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/de/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/el/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/en_GB/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/es/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/fa/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/fr/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/gl/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/he/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/hr/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/hu/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/id/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/it/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/ja/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/kk/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/km/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/lg/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/nl/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/pl/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/pt/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/pt_BR/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/ru/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/sk/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/sr/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/sr at latin/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/sv/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/tr/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/uk/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/vi/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/zh_CN/LC_MESSAGES/deadbeef.mo
> deadbeef.i686: W: file-not-in-%lang
> /usr/share/locale/zh_TW/LC_MESSAGES/deadbeef.mo

Locales files should be marked as such.
https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

> deadbeef.i686: E: invalid-desktopfile /usr/share/applications/deadbeef.desktop
> file contains group "Play Shortcut Group", but groups extending the format
> should start with "X-"
> deadbeef.i686: E: invalid-desktopfile /usr/share/applications/deadbeef.desktop
> file contains group "Pause Shortcut Group", but groups extending the format
> should start with "X-"
> deadbeef.i686: E: invalid-desktopfile /usr/share/applications/deadbeef.desktop
> file contains group "Stop Shortcut Group", but groups extending the format
> should start with "X-"
> deadbeef.i686: E: invalid-desktopfile /usr/share/applications/deadbeef.desktop
> file contains group "Next Shortcut Group", but groups extending the format
> should start with "X-"
> deadbeef.i686: E: invalid-desktopfile /usr/share/applications/deadbeef.desktop
> file contains group "Prev Shortcut Group", but groups xtending the format
> should start with "X-"

See https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

Read the guidelines and fix all of the above issues, that should be a good
starting point, then run rpmlint again on both the binary rpm and the source
rpm. Again, fix as much as you can, then post links to the updated versions of
the spec and srpm.

Hope this helps,
Xavier


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.