[Bug 1718] Review request: spek - Free acoustic spectrum analyzer

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1718





--- Comment #3 from Prabin Kumar Datta <linux.n.pkd at gmail.com>  2011-05-09 23:46:12 ---
* MUST: rpmlint must be run on every package                           [OK  ]
* Other:                                                               [Fix ]
/---
#Used to add missing semicolons in the desktop file
desktop-file-install \
 --dir=%{buildroot}%{_datadir}/applications \
%{buildroot}%{_datadir}/applications/%{name}.desktop
-----/

1. Where you have added missing semicolons in the desktop file?
missing patch file, I guess.
2. Are you sure about the use of desktop-file-install?
If your package installs a desktop file itself (and it puts it in the right
place) you should call desktop-file-validate on it to ensure that it's OK.
Otherwise,
If your package doesn't install the file, you should use desktop-file-install
to put it in place instead of just copying it.

http://fedoraproject.org/wiki/PackagingGuidelines#Desktop_files


-- 
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.