Code review: avidemux patch to use system libass

[Richard Shaw]

On Thu, May 26, 2011 at 5:49 AM, Hans de Goede <j.w.r.degoede at gmail.com> wrote:
> Hi,
>
> On 05/26/2011 03:03 AM, Richard Shaw wrote:
>>
>> I think I've managed to unbundle libass from avidemux but would like
>> another set of eyes on my patch[1] before submitting a build and
>> closing the bug report[2[.
>>
>> I'm not much of a programmer and know even less about cmake so I
>> pretty much fumbled my way through it. Any comments are welcome.
>
> The patch looks sane to me. What I always do to make sure the
> bundled copy does not accidentally get used is "rm -r" it from
> %prep

I forgot to mention I did that :) Ok, in that case I'll do a little
more testing with my local version before pushing the changes into
rpmfusion.

Thanks!
Richard