[Bug 2405] Review Request: ultrastardx - A free OpenSource karaoke game

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2405

Karel Volný <kvolny at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |kvolny at redhat.com
             Blocks|2                           |3
         AssignedTo|rpmfusion-package-review at rp |kvolny at redhat.com
                   |mfusion.org                 |

--- Comment #1 from Karel Volný <kvolny at redhat.com> 2012-08-14 15:27:57 CEST ---
Hi,

a few findings before a full review ...

* note that it'd be nice to package also the data files available to download

* what is the reason to use the svn checkout?
- I know, the release is quite old but were there any changes relevant to linux
that are too hard to backport?
doesn't the upstream plan a fresh release soon?

* when using svn snapshot, please do not use the revision number as a Version
see http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

instead, you should use Release like "1.20120613svn"

* what is the reason to export empty LD_FLAGS?

* debuginfo files should be handled automatically, why to include
"/usr/lib/debug/usr/bin" in %files (which is the source of rpmlint error)?
- and in addition, debuginfos should go into separate package

btw, this dir could be written as %{_prefix}/lib%{_bindir}

* it doesn't build for me ... probably a missing dependency?

...
Compiling lib/ffmpeg/avcodec.pas
Compiling lib/ffmpeg/avutil.pas
Fatal: Can't find unit mathematics used by avutil
Fatal: Compilation aborted
Error: /usr/bin/ppcx64 returned an error exitcode (normal if you did not
specify a source file to be compiled)
make[1]: *** [../game/ultrastardx] Error 1
make[1]: Leaving directory `/home/kvolny/rpmbuild/BUILD/ultrastardx/src'
make: *** [all] Error 2

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.