[Bug 2421] booh - Static web-album generator

RPM Fusion Bugzilla noreply at rpmfusion.org
Thu Aug 16 01:45:06 CEST 2012 

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2421

Lameire Alexis <alexisis-pristontale at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |alexisis-pristontale at hotmai
                   |                            |l.com

--- Comment #1 from Lameire Alexis <alexisis-pristontale at hotmail.com> 2012-08-16 01:45:06 CEST ---
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== C/C++ ====
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
     present.
     Note: Unversioned so-files in non-devel package (fix or
     explain):booh-0.9.3-1.fc17.x86_64.rpm :
     /usr/local/lib64/ruby/site_ruby/booh/libadds.so
     (libadds is a ruby binding don't need to be versionned)

==== Generic ====
[x]: EXTRA Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
     more warning flags is applied in additions than fedora flags, it's don't
change the beavor of resulting library.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.

[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
     there is such a file.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[!]: MUST Package complies to the Packaging Guidelines
     see bottom comments.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "UNKNOWN", "*No copyright* UNKNOWN", "*No copyright* GENERATED FILE",
     "GENERATED FILE" For detailed output of licensecheck see file:
     /home/alexises/booh/licensecheck.txt
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
     Note: Installation errors (see attachment)

[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[-]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Package installs properly.
     Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines

desktop-file-validate don't applied into the desktop file at install steap

desktop database is not updated :
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database

icon cache must be updated :
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

you don't need to define as your own the ruby releated path. include the
ruby-devel package. http://fedoraproject.org/wiki/Packaging:Ruby#Macros

flowplayer can be usefull with another tool and must be packaged separetely.

icone must be installed into %{_datadir}/icons/hicolor/ in all size avalable
according the freedesktop standart
-------------------
INFO: mock.py version 1.1.22 starting...
State Changed: init plugins
INFO: selinux enabled
State Changed: start
Mock Version: 1.1.22
INFO: Mock Version: 1.1.22
State Changed: lock buildroot
INFO: installing package(s):
/home/alexises/booh/results/booh-0.9.3-1.fc17.x86_64.rpm
/home/alexises/booh/results/booh-debuginfo-0.9.3-1.fc17.x86_64.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-17-x86_64/root/',
'install', '/home/alexises/booh/results/booh-0.9.3-1.fc17.x86_64.rpm',
'/home/alexises/booh/results/booh-debuginfo-0.9.3-1.fc17.x86_64.rpm',
'--setopt=tsflags=nocontexts']
Erreur : Paquet : booh-0.9.3-1.fc17.x86_64 (/booh-0.9.3-1.fc17.x86_64)
             Requiert : mplayer
Erreur : Paquet : booh-0.9.3-1.fc17.x86_64 (/booh-0.9.3-1.fc17.x86_64)
             Requiert : ruby(abi) = 1.8
             Installé  : ruby-libs-1.9.3.194-14.fc17.x86_64 (@updates-released)
                 ruby(abi) = 1.9.1
             Disponible : ruby-libs-1.9.3.194-10.1.fc17.i686 (fedora)
                 ruby(abi) = 1.9.1
Erreur : Paquet : booh-0.9.3-1.fc17.x86_64 (/booh-0.9.3-1.fc17.x86_64)
             Requiert : ffmpeg
 Vous pouvez essayer d'utiliser --skip-broken pour contourner le problème
 Vous pouvez essayer d'exécuter : rpm -Va --nofiles --nodigest

Rpmlint
-------
Checking: booh-0.9.3-1.fc17.src.rpm
          booh-0.9.3-1.fc17.x86_64.rpm
          booh-debuginfo-0.9.3-1.fc17.x86_64.rpm
booh.src: I: enchant-dictionary-not-found en_US
booh.src: E: specfile-error -e:1: Use RbConfig instead of obsolete and
deprecated Config.
booh.src: E: specfile-error -e:1: Use RbConfig instead of obsolete and
deprecated Config.
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/lightparser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/comment.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/UTF-16.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/doctype.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encoding.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parseexception.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/instruction.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/SHIFT-JIS.rb
booh.x86_64: E: dir-or-file-in-usr-local /usr/local/lib64/ruby/site_ruby/booh
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers
booh.x86_64: E: incorrect-fsf-address
/usr/share/booh/themes/dark/metadata/parameters.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/validation/validationexception.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/ISO-8859-15.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/UNILE.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/US-ASCII.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/xmltokens.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/GtkAutoTable.rb
booh.x86_64: E: incorrect-fsf-address
/usr/local/share/ruby/site_ruby/booh/GtkAutoTable.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/streamparser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/rexml.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/streamlistener.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/source.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/text.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/output.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/document.rb
booh.x86_64: E: dir-or-file-in-usr-local /usr/local/share/ruby/site_ruby/booh
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/booh-lib.rb
booh.x86_64: E: incorrect-fsf-address
/usr/local/share/ruby/site_ruby/booh/booh-lib.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/xpath_parser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/validation/relaxng.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/syncenumerator.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/sax2listener.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/validation
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/lib64/ruby/site_ruby/booh/libadds.so
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/child.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/dtd/notationdecl.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/UndoHandler.rb
booh.x86_64: E: incorrect-fsf-address
/usr/local/share/ruby/site_ruby/booh/UndoHandler.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/xpathparser.rb
booh.x86_64: E: incorrect-fsf-address
/usr/share/booh/themes/simple/metadata/parameters.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/dtd/elementdecl.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parent.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/html-merges.rb
booh.x86_64: E: incorrect-fsf-address
/usr/local/share/ruby/site_ruby/booh/html-merges.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/treeparser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/version.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/light
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/namespace.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/xmldecl.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/ISO-8859-1.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/cdata.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/quickpath.rb
booh.x86_64: E: incorrect-fsf-address
/usr/share/booh/themes/cardu/metadata/parameters.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/dtd
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/dtd/attlistdecl.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/validation/validation.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/SHIFT_JIS.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/attlistdecl.rb
booh.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/booh
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/pullparser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/sax2parser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/dtd/dtd.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/element.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/functions.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/UTF-8.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/config.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/node.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/EUC-JP.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/xpath.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/ICONV.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/dtd/entitydecl.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/attribute.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/ultralightparser.rb
booh.x86_64: E: incorrect-fsf-address
/usr/share/booh/themes/sbs/metadata/parameters.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/light/node.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/encodings/CP-1252.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/entity.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml/parsers/baseparser.rb
booh.x86_64: E: dir-or-file-in-usr-local
/usr/local/share/ruby/site_ruby/booh/rexml
booh-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/booh-0.9.3/ext/rbbooh.cc
3 packages and 0 specfiles checked; 82 errors, 1 warnings.


Rpmlint (installed packages)
----------------------------
# rpmlint booh booh-debuginfo
(none): E: no installed packages by name booh
(none): E: no installed packages by name booh-debuginfo
0 packages and 0 specfiles checked; 0 errors, 0 warnings.
# echo 'rpmlint-done:'

Requires
--------
booh-0.9.3-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):

    /usr/bin/ruby  
    ImageMagick  
    exif  
    ffmpeg  
    gimp  
    libatk-1.0.so.0()(64bit)  
    libc.so.6()(64bit)  
    libcairo.so.2()(64bit)  
    libcrypt.so.1()(64bit)  
    libdl.so.2()(64bit)  
    libexiv2.so.11()(64bit)  
    libfontconfig.so.1()(64bit)  
    libfreetype.so.6()(64bit)  
    libgcc_s.so.1()(64bit)  
    libgcc_s.so.1(GCC_3.0)(64bit)  
    libgdk-x11-2.0.so.0()(64bit)  
    libgdk_pixbuf-2.0.so.0()(64bit)  
    libgio-2.0.so.0()(64bit)  
    libglib-2.0.so.0()(64bit)  
    libgobject-2.0.so.0()(64bit)  
    libgtk-x11-2.0.so.0()(64bit)  
    libm.so.6()(64bit)  
    libpango-1.0.so.0()(64bit)  
    libpangocairo-1.0.so.0()(64bit)  
    libpangoft2-1.0.so.0()(64bit)  
    libpthread.so.0()(64bit)  
    librt.so.1()(64bit)  
    libruby.so.1.9()(64bit)  
    mplayer  
    rtld(GNU_HASH)  
    ruby(abi) = 1.8
    ruby-gettext-package >= 0.8.0
    ruby-gtk2 >= 0.12

booh-debuginfo-0.9.3-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):


Provides
--------
booh-0.9.3-1.fc17.x86_64.rpm:

    booh = 0.9.3-1.fc17
    booh(x86-64) = 0.9.3-1.fc17
    libadds.so()(64bit)  

booh-debuginfo-0.9.3-1.fc17.x86_64.rpm:

    booh-debuginfo = 0.9.3-1.fc17
    booh-debuginfo(x86-64) = 0.9.3-1.fc17

MD5-sum check
-------------
http://www.booh.org/packages/booh-0.9.3.tar.bz2 :
  MD5SUM this package     : ab39455accde3c581fde1eccc2944344
  MD5SUM upstream package : ab39455accde3c581fde1eccc2944344


Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
Command line :/bin/fedora-review -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2421
External plugins:

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the rpmfusion-developers mailing list