[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034

--- Comment #14 from Richard <hobbes1069 at gmail.com> 2012-01-10 23:14:47 CET ---
I was looking at the files in the package and had some observations:
$ rpm -qlp sinthgunt-2.0.3-2.fc16.noarch.rpm
/usr/bin/sinthgunt
/usr/bin/youtube-dl-sinthgunt
/usr/lib/python2.7/site-packages/Sinthgunt
/usr/lib/python2.7/site-packages/Sinthgunt/__init__.py
/usr/lib/python2.7/site-packages/Sinthgunt/__init__.pyc
/usr/lib/python2.7/site-packages/Sinthgunt/__init__.pyo
/usr/lib/python2.7/site-packages/Sinthgunt/app.py
/usr/lib/python2.7/site-packages/Sinthgunt/app.pyc
/usr/lib/python2.7/site-packages/Sinthgunt/app.pyo
/usr/lib/python2.7/site-packages/sinthgunt-2.0.3-py2.7.egg-info
/usr/share/applications/sinthgunt.desktop
/usr/share/doc/sinthgunt-2.0.3
/usr/share/doc/sinthgunt-2.0.3/LICENSE.txt
/usr/share/doc/sinthgunt-2.0.3/README.txt
/usr/share/pixmaps/sinthgunt.png
/usr/share/sinthgunt
/usr/share/sinthgunt/icon.png
/usr/share/sinthgunt/logo.png
/usr/share/sinthgunt/presets.xml
/usr/share/sinthgunt/sinthgunt.glade
/usr/share/sinthgunt/sinthgunt.html

Putting icons in /usr/share/pixmaps is pretty much depreciated but not
forbidden. It would be better to put them in the appropriate /usr/share/icons/
location. I also noticed that there's sinthgunt.pnd which is identical to
logo.png, that's probably because the logo is used in the html file. Also,
sinthgunt is not square:

$ file pixmaps/sinthgunt.png
pixmaps/sinthgunt.png: PNG image data, 128 x 93, 8-bit/color RGBA,
non-interlaced

but icon.png is:

$ file sinthgunt/icon.png
sinthgunt/icon.png: PNG image data, 24 x 24, 8-bit/color RGBA, non-interlaced

BUT it's only 24x24 and the Fedora guidelines indirectly require at least a
48x48 icon.

Ick.

I did all this remotely so I'm not sure what the image files even look like.
I'll take a look at that and possible solutions tonight at home.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.