[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034

--- Comment #16 from Richard <hobbes1069 at gmail.com> 2012-01-11 16:01:51 CET ---
(In reply to comment #15)
> Thanks for the comment. I will try to solve these as soon as I can (mostly, by
> the end of the week).
> 
> If you can point me to a guideline on what should we do for the icons. Do we
> provide a new one that is square, do we use the one that upstream provide even
> if it's not good, etc? It would help as it is the first time that this problem
> happen to a package I own.

Ok, here's the (convoluted) short version :)

The packaging guidelines say we need to adhere to freedesktop's Desktop Entry
Specification[1] which in turn says we have to follow the Icon Theme
Specification[2], which says we should supply a 48x48 icon as a minimum[3].

[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
[2]
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
[3]
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons

Ok, now what to do about it? There's no absolute requirement that I know of
that an icon be "square", but if you look in /usr/share/icons/hicolor you'll
see that all (or the vast majority) of the directories indicate a 1:1 ratio.

If upstream is at all active, I would petition them for a 48x48 icon and a
scalable icon. If you have the scalable, then you can create your own 48x48
(either statically and include it as a Source: or on the fly during package
building using mogify from ImageMagick).

Ok, having actually looked at the images now...

The icon is just one rampant horse while the logo is two with a film reel in
between. I think this makes a much better icon but we still need to get it in a
usable resolution. I'm not a graphic artist but it's pretty easy to increase
the  height since the background is white to square it up to 128x128. Then we
can make a scaled version in 48x48. I would install both. If you can manage
that I'd send it upstream for inclusion. If not, I'll see what I can do but I'm
not sure when I can get to it.

Another fix that's needed is that the Icon tag in the desktop file uses the
extension of the icon. There's only two options:

1. Use absolute path to the icon file (including the extension)
2. Use just the basename of the icon file and let the DM figure out the
extension (preferred). 

So the Icon tag in the desktop file would just be:
Icon=sinthgunt

Ok, last issue. Because this package will not own the directory the icon goes
into, per the guidelines (another convoluted issue) we muse Require: the
package that does own the directory, in this case "hicolor-icon-theme". Since
this is a side effect and not an explicit requirement, not everyone knows about
this so it would be good to add a comment above it like:

# We must require the package that owns the directories where the icon file is
being installed.
Require: hicolor-icon-theme

OK! I think that's it for now! :) Just remember we need to push upstream to
accept these changes as much as possible. That will make your job MUCH easier
in the future.


Richard

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.