[Bug 2036] Review Request: chromaprint-tools - Chromaprint audio fingerprinting tools

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2036

--- Comment #23 from Richard <hobbes1069 at gmail.com> 2012-01-14 21:41:10 CET ---
Ok, just a couple of things:

1. Were you not using the "%cmake" macro for a reason? Seemed to work for me
and put the libraries in the right place (/usr/lib64) which is where they need
to be in order to be removed later in %{_libdir}. I'm assuming you build a
32bit package? Otherwise it would have failed for you.

I changed your cmake line to:
%cmake -DBUILD_EXAMPLES=on -DBUILD_TESTS=off -DCMAKE_BUILD_TYPE=RelWithDebInfo

The cmake build type is optional but I've gotten to where I like to set it on
all my cmake packages.

It doesn't look like much but the %cmake macro does a lot for you. Too see it
just do this:

$ rpm -E %cmake

  CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic}" ; export
CFLAGS ; 
  CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic}" ; export
CXXFLAGS ; 
  FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic
-I/usr/lib64/gfortran/modules}" ; export FFLAGS ; 
  LDFLAGS="${LDFLAGS:--Wl,-z,relro }" ; export LDFLAGS ; 
  /usr/bin/cmake \
        -DCMAKE_VERBOSE_MAKEFILE=ON \
        -DCMAKE_INSTALL_PREFIX:PATH=/usr \
        -DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib64 \
        -DINCLUDE_INSTALL_DIR:PATH=/usr/include \
        -DLIB_INSTALL_DIR:PATH=/usr/lib64 \
        -DSYSCONF_INSTALL_DIR:PATH=/etc \
        -DSHARE_INSTALL_PREFIX:PATH=/usr/share \
%if "lib64" == "lib64" 
        -DLIB_SUFFIX=64 \
%endif 
        -DBUILD_SHARED_LIBS:BOOL=ON

You can see it sets the cflags and install prefix among other things.

2. rpmlint output:
$ rpmlint *.rpm
chromaprint-tools.src: W: spelling-error %description -l en_US fpcalc ->
calcify
chromaprint-tools.x86_64: W: no-manual-page-for-binary fpcalc
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

looks good!

I'll do the full review as soon as I can.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.