[Bug 2101] Review request: vbam - High compatibility Gameboy Advance Emulator combining many VBA developments

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2101

--- Comment #9 from Andrea Musuruane <musuruan at gmail.com> 2012-01-22 15:43:18 CET ---
(In reply to comment #7)
> Thanks a lot for your help; I've incorporated a lot of your suggestions, but I
> need to talk to a dev when I can time to fix the rest. Since 1.8.0.1054 won't
> build, I'd rather get that working first as I have to talk to a dev about that
> anyway.
> 
> Also if it's necessary or preferred, I can make a man page for gvbam.

No, it's not necessary if gvbam can be run from a GUI.

> Note that no new rpmlint errors have been introduced or removed (excluding the
> fix of /usr/bin/vbam's man page)

* First you have to better understand how subpackaging works. There is a
package created with the "Summary:        This is a dummy package that will not
be created" and that is the SRPM!

Try this:
$ rpm -qpi vbam-1.8.0.1001-2.fc16.src.rpm

You'll read that summary!

Have a look at spec files that builds subpackages in RPM Fusion CVS. For
example:
http://cvs.rpmfusion.org/viewvc/rpms/desmume/devel/desmume.spec?revision=1.14&root=free&view=markup

* The BuilRequires are needed for the SRPM to build the variuos RPMs. So there
is no point in dividing them in two different section.

* Why the sdl subpackage conflicts with vbam package (there is no binary
package built with this name)? Moreover a user could install both subpackages.

* A lot of comment are useless. E.g:

#
# spec file for vbam

Well... we know :) Please remove them - it just makes the spec files a bit less
readable.

* You didn't use the %cmake macro and therefore no compile output is shown.

* post, postun, posttrans section are needed only for the gtk subpackage (the
one that has a menu entry). Can the sdl package be run from a menu or does it
requires the command line?

* %config(noreplace) /etc/%{name}.cfg 
This can be a problem. There can't be the same file in two different packages.
Otherwise a conflict arises.

* There is still the problem with the empty debug package.

* Have a look at the mandriva package:
http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/vbam/releases/1.8.0.1054/1/

There is patch. It may help you to build v1.8.0.1054. Please remember that
Fedora and Mandriva have different packaging guidelines.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.