[Bug 2101] Review request: vbam - High compatibility Gameboy Advance Emulator combining many VBA developments

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2101

--- Comment #11 from Jeremy Newton <alexjnewt at hotmail.com> 2012-01-23 03:36:33 CET ---
I managed to get the %cmake macro working and also fixed the debug striping
issue. I also added a vbam-common package containing the common /etc/vbam.cfg
file, which gtk and sdl depends on, in attempt to fix any conflicts. I also
included some other fixes that I would hope fixes most the loose ends.

Unfortunately running rpmlint on the debug pakage has given me a lot of errors
:(

vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/window.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/debugger.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/filters.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/configfile.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/gameboyadvanceconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/system.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/displayconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/exprNode.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/common/SoundDriver.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/gameboyconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/text.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/main.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/tools.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/generalconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/windowcallbacks.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/filters.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/displayconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/screenarea-cairo.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/joypadconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/inputSDL.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/inputSDL.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/screenarea-opengl.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/cheatlist.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/directoriesconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/exprNode.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/cheatlist.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/common/SoundSDL.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/SDL.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/cheatedit.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/filters/admame.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/joypadconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/soundconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/screenarea-opengl.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/tools.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/filters.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/directoriesconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/filters.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/screenarea.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/soundconfig.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/common/SoundSDL.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/sdl/text.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/gameboyadvanceconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/screenarea.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/configfile.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/filters/hq2x.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/gameboyconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/screenarea-cairo.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/filters/interp.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/window.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/common/Types.h
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/generalconfig.cpp
vbam-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/vbam-1.8.0.1001/src/gtk/cheatedit.cpp

I'm not sure exactly what these mean, or even if they are critical to be
honest. I am new at this packaging business after all :P

Anyway, here's the links:
SPEC:
http://dl.dropbox.com/u/42480493/vbam.spec
SRPM:
http://dl.dropbox.com/u/42480493/vbam-1.8.0.1001-4.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.