[Bug 2098] Review request: dolphin-emu - Gamecube / Wii / Triforce Emulator
RPM Fusion Bugzilla
noreply at rpmfusion.org
Wed Jul 4 22:32:00 CEST 2012
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098
--- Comment #66 from Alec Leamas <leamas.alec at gmail.com> 2012-07-04 22:32:00 CEST ---
(In reply to comment #65)
> (In reply to comment #64)
> > Hmm... odd, there must have been an glitch when I last pulled the source.
> > I'll do a repull and reupload the SRPM when I get home later today.
>
> Very odd indeed, I'm not sure what went wrong there.
>
> None the less, I ran the script in SOURCE1 and rebuilt the rev:
> http://dl.dropbox.com/u/42480493/dolphin-emu-3.0-10.fc17.src.rpm
>
> If there is any more issues, it's likely an issue with the git I'm pulling
> from. Also, I pulled it twice just to make sure, diff -r seems to give
> consistent results now, though md5sums of the tar.xz do not match.
Out of the top of my head, standard git retains modification times when
checking out a commit, but resets them when checking out a tag. So this is as
expected.
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
===== MUST items =====
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Buildroot is not present
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Permissions on files are set properly.
[x]: Package does not contain duplicates in %files.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* UNKNOWN", "zlib/libpng GPL", "UNKNOWN", "BSD (3 clause)
GPL", "GPL", "GPL (v2 or later)", "BSD (3 clause)", "*No copyright* BSD",
"GPL (v2 or later) (with incorrect FSF address)", "*No copyright*
GENERATED FILE", "GPL (unversioned/unknown version) GPL", "GPL (v2) (with
incorrect FSF address)" For detailed output of licensecheck see file:
/home/mk/FedoraReview/src/dolphin-emu/licensecheck.txt
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ascii characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
===== SHOULD items =====
[x]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.
===== EXTRA items =====
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: dolphin-emu-3.0-10.fc17.src.rpm
dolphin-emu-debuginfo-3.0-10.fc17.i686.rpm
dolphin-emu-3.0-10.fc17.i686.rpm
dolphin-emu.src: W: spelling-error Summary(en_US) Gamecube -> Game cube,
Game-cube, Gamecock
dolphin-emu.src: W: invalid-url Source1: dolphin-emu-extra.tar.xz
dolphin-emu.src: W: invalid-url Source0: dolphin-emu-3.0.tar.xz
dolphin-emu-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/dolphin-emu-3.0/Source/Core/Core/Src/DSP/DSPHWInterface.cpp
[ another 12 incorrect-fsf-address removed ]
dolphin-emu.i686: W: spelling-error Summary(en_US) Gamecube -> Game cube,
Game-cube, Gamecock
3 packages and 0 specfiles checked; 13 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint dolphin-emu dolphin-emu-debuginfo
dolphin-emu.i686: I: enchant-dictionary-not-found en_US
dolphin-emu-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/dolphin-emu-3.0/Source/Core/Core/Src/DSP/DSPHWInterface.cpp
[ another 12 incorrect-fsf-address removed ]
2 packages and 0 specfiles checked; 13 errors, 0 warnings.
# echo 'rpmlint-done:'
Requires
--------
dolphin-emu-debuginfo-3.0-10.fc17.i686.rpm (rpmlib, GLIBC filtered):
dolphin-emu-3.0-10.fc17.i686.rpm (rpmlib, GLIBC filtered):
/bin/sh
hicolor-icon-theme
libCg.so
libCgGL.so
libGL.so.1
libGLEW.so.1.6
libGLU.so.1
libSDL-1.2.so.0
libSOIL.so.1
libX11.so.6
libXext.so.6
libXrandr.so.2
libao.so.4
libao.so.4(LIBAO4_1.1.0)
libasound.so.2
libasound.so.2(ALSA_0.9)
libasound.so.2(ALSA_0.9.0rc4)
libatk-1.0.so.0
libavcodec.so.53
libavcodec.so.53(LIBAVCODEC_53)
libavformat.so.53
libavformat.so.53(LIBAVFORMAT_53)
libavutil.so.51
libavutil.so.51(LIBAVUTIL_51)
libbluetooth.so.3
libc.so.6
libcairo.so.2
libclrun.so.0.16
libfreetype.so.6
libgcc_s.so.1
libgdk-x11-2.0.so.0
libgdk_pixbuf-2.0.so.0
libglib-2.0.so.0
libgobject-2.0.so.0
libgomp.so.1
libgomp.so.1(GOMP_1.0)
libgomp.so.1(OMP_1.0)
libgtk-x11-2.0.so.0
liblzo2.so.2
libm.so.6
libopenal.so.1
libpango-1.0.so.0
libportaudio.so.2
libpthread.so.0
libpulse.so.0
libpulse.so.0(PULSE_0)
libsfml-network.so.1.6
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libswscale.so.2
libswscale.so.2(LIBSWSCALE_2)
libwx_baseu-2.8.so.0
libwx_baseu-2.8.so.0(WXU_2.8)
libwx_gtk2u_adv-2.8.so.0
libwx_gtk2u_adv-2.8.so.0(WXU_2.8)
libwx_gtk2u_aui-2.8.so.0
libwx_gtk2u_aui-2.8.so.0(WXU_2.8)
libwx_gtk2u_aui-2.8.so.0(WXU_2.8.9)
libwx_gtk2u_core-2.8.so.0
libwx_gtk2u_core-2.8.so.0(WXU_2.8)
libz.so.1
rtld(GNU_HASH)
Provides
--------
dolphin-emu-debuginfo-3.0-10.fc17.i686.rpm:
dolphin-emu-debuginfo = 3.0-10.fc17
dolphin-emu-debuginfo(x86-32) = 3.0-10.fc17
dolphin-emu-3.0-10.fc17.i686.rpm:
dolphin-emu = 3.0-10.fc17
dolphin-emu(x86-32) = 3.0-10.fc17
MD5-sum check
-------------
Using local file /home/mk/FedoraReview/src/dolphin-emu-3.0.tar.xz as upstream
/home/mk/FedoraReview/src/dolphin-emu-3.0.tar.xz :
MD5SUM this package : 6fb4c50ddb22cd6413b24ac76bd2735f
MD5SUM upstream package : 7cda1c13c6f80d3b4b7f44c17df27a6c
However, diff -r shows no differences
Generated by fedora-review 0.2.0git (0be4d03) last change: 2012-07-03
Applied tests: Generic C/C++
Command line :./fedora-review -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2098 -m
fedora-17-i386-rpmfusion_nonfree
External plugins:
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the rpmfusion-developers
mailing list